Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always set correct chat_id for DC_EVENT_REACTIONS_CHANGED #5419

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix: always set correct chat_id for DC_EVENT_REACTIONS_CHANGED #5419

merged 2 commits into from
Apr 2, 2024

Commits on Apr 1, 2024

  1. add failing test for #5418 (wrong DC_EVENT_REACTIONS_CHANGED)

    @r10s
    r10s committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    4e13099 View commit details
    Browse the repository at this point in the history

  2. reactions are not a 'probably private reply' 

    `is_probably_private_reply()` checks
if a message should better go to the one to one chat
instead of the chat already identified by the `In-Reply-To`.
this functionality is needed to make "Reply Privately" work.

however, this functionality is never true for reactions.
if we would return `true` here, own reactions seen by a second device
would not get the correct chat assiged.
    @r10s
    r10s committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    3f315fe View commit details
    Browse the repository at this point in the history