-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ffi): Add DC_STR_CANT_DECRYPT_OUTGOING_MSGS define #5664
base: main
Are you sure you want to change the base?
Conversation
This looks good but if we merge this we should also change the string in the Android repo because it is the string that is actually used and gets translated. Core fallback is normally not used at all. |
tbh, not sure if the new wording is better. the "some outgoing messages" seems more vague than "each other's outgoing messages". and the wording adopts to rarer cases (as @gerryfrancis was using the same device during testing), however probably weakens the string for the majority of cases (user really setting up a second device wrongly). all in all i found the old wording more on point and actionable ("to fix that") but yeah, it is a minor one and if we think the rarer cases happen often enough outside artificial testing scenarios, we can go for it and i am also fine with it. for translations: in fact, the string is not yet translated at all yet (what a luck!, so we can do changes without annoying translators :), also the corresponding define in deltachat.h is missing |
0481d19
to
4dce996
Compare
I agree with @r10s that the existing phrasing is probably better for the most users, but just in case tried to improve it once more |
954e59c
to
f428438
Compare
f428438
to
21c9c06
Compare
"Could not decrypt outgoing messages that may be from Delta Chat on your other device." can be read as "Could not decrypt ... on your other device." So we have these options:
|
I don't think so, even Google Translate feels the difference (when translating to Spanish f.e.) if i put commas as follows: |
As @gerryfrancis said,
So maybe making less assumtions about what the user does wrong is better. Just in case, the previous discussion of this stock string: #5176 (comment)