Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

start test suite for a few "happy paths", integration with travis #100

Closed
hpk42 opened this issue Jan 26, 2018 · 10 comments
Closed

start test suite for a few "happy paths", integration with travis #100

hpk42 opened this issue Jan 26, 2018 · 10 comments
Assignees
Milestone

Comments

@hpk42
Copy link
Contributor

hpk42 commented Jan 26, 2018

From a discussion with @r10s today: before going for g-play it'd be good to have automated tests which run with each commit/push to the delta-core codebase. @flub has done some work on creating python bindings for delta-core and i have experience in writing tests (have eg authored http://pytest.org). So this issue here is about writing a few basic tests (create chat, send a message, receive a message) and integrating it into travis such that the tests run on PRs and pushed commits.

@hpk42 hpk42 added this to the Release 1.0 milestone Jan 26, 2018
@hpk42 hpk42 assigned hpk42 and flub Jan 26, 2018
@testbird testbird removed this from the Release 1.0 milestone Mar 4, 2018
@r10s r10s added this to the Release 1.0 milestone Mar 5, 2018
@t-oster
Copy link
Contributor

t-oster commented Jun 5, 2018

nice idea. Any FakeSMTP/IMAP libraries which can run during the test and assert incoming/outgoing messages?

@flub
Copy link
Member

flub commented Jun 5, 2018

The python stdlib has a stmpd implementation which can probably be used. imap might be some more work.

@t-oster
Copy link
Contributor

t-oster commented Jun 5, 2018

well there is http://www.icegreen.com/greenmail/ but this need java

@ralphtheninja
Copy link
Member

I'm going to try and push this further. Enough discussing 😉

#250 is a start to get Travis up and running.

@ralphtheninja
Copy link
Member

ralphtheninja commented Aug 26, 2018

I've tested deltachat-node with Greenmail but I can't get it to work. A client can connect to IMAP and SMTP (and IMAPS and SMTPS works as well), but sending messages back and forth doesn't work.

Perhaps I should clarify a bit. It works to send messages, but writing integration tests with multiple users is difficult, i.e. send a message from client1 and check that client2 received a message etc.

@r10s
Copy link
Member

r10s commented Aug 27, 2018

cc @hpk42

@ralphtheninja
Copy link
Member

I'll try to write some more unit tests in deltachat-node using greenmail as backend just to see how for it can take me. Maybe we could have a more extensive setup for integration tests, more as in a "real" IMAP/SMTP environment in the future.

@ralphtheninja
Copy link
Member

Also see deltachat/deltachat-node#98

@flub
Copy link
Member

flub commented Aug 27, 2018

Starting the greenmail docker container was what I was thinking of doing for the tests as well, so it makes sense to use this in the node bindings tests too.

@hpk42
Copy link
Contributor Author

hpk42 commented Oct 1, 2018

python bindings have a test suite https://github.com/deltachat/deltachat-core/tree/master/python/tests
and the tests run against travis. creating a follow up issues #339 and closing this one here.

@hpk42 hpk42 closed this as completed Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants