-
-
Notifications
You must be signed in to change notification settings - Fork 26
Enable Travis #250
Enable Travis #250
Conversation
install: | ||
- sudo apt install -y libssl-dev libsqlite3-dev libbz2-dev zlib1g-dev | ||
|
||
script: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r10 WDYT about adding a Makefile
in the root of the project so we can put common commands in there, e.g. make build
, make test
, make install
, make uninstall
etc. This would also allow us to simplify README.md
and we can instead refer to make commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense, however i have no idea how this relates to meson/ninja (cc @flub)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well make build
would essentially do mkdir -p builddir && cd builddir && meson && ninja
. It's merely a refactoring step as I see it.
- sudo apt install -y libssl-dev libsqlite3-dev libbz2-dev zlib1g-dev | ||
|
||
script: | ||
- mkdir -p builddir && cd builddir && meson && ninja -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would ideally be make build
and later on when we have tests implemented make build && make test
.
- pushd cyrus-sasl2-2.1.27~101-g0780600+dfsg.orig && ./autogen.sh && make && sudo make install && popd | ||
|
||
install: | ||
- sudo apt install -y libssl-dev libsqlite3-dev libbz2-dev zlib1g-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing ninja-build
above since installing it via apt
yields a too old version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also installing meson
before this step since installing via apt
fails (no such package).
lgtm (but this is not worth much, do not have much experience with travis or makefiles :) @ralphtheninja awesome you push this forward :) |
@ralphtheninja it works :) :) :) :) 👍 👍 👍 |
This makes sure to install everything we need and then builds the library and gives a stepping stone to start implementing tests.