Skip to content
This repository has been archived by the owner on Nov 25, 2022. It is now read-only.

Enable Travis #250

Merged
merged 1 commit into from
Aug 26, 2018
Merged

Enable Travis #250

merged 1 commit into from
Aug 26, 2018

Conversation

ralphtheninja
Copy link
Member

This makes sure to install everything we need and then builds the library and gives a stepping stone to start implementing tests.

install:
- sudo apt install -y libssl-dev libsqlite3-dev libbz2-dev zlib1g-dev

script:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r10 WDYT about adding a Makefile in the root of the project so we can put common commands in there, e.g. make build, make test, make install, make uninstall etc. This would also allow us to simplify README.md and we can instead refer to make commands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, however i have no idea how this relates to meson/ninja (cc @flub)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well make build would essentially do mkdir -p builddir && cd builddir && meson && ninja. It's merely a refactoring step as I see it.

- sudo apt install -y libssl-dev libsqlite3-dev libbz2-dev zlib1g-dev

script:
- mkdir -p builddir && cd builddir && meson && ninja -v
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would ideally be make build and later on when we have tests implemented make build && make test.

- pushd cyrus-sasl2-2.1.27~101-g0780600+dfsg.orig && ./autogen.sh && make && sudo make install && popd

install:
- sudo apt install -y libssl-dev libsqlite3-dev libbz2-dev zlib1g-dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing ninja-build above since installing it via apt yields a too old version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also installing meson before this step since installing via apt fails (no such package).

@r10s
Copy link
Member

r10s commented Aug 26, 2018

lgtm (but this is not worth much, do not have much experience with travis or makefiles :)
however, as this does not affect other parts, just give it a try )

@ralphtheninja awesome you push this forward :)

@r10s r10s merged commit 2d2c60f into master Aug 26, 2018
@r10s
Copy link
Member

r10s commented Aug 26, 2018

@ralphtheninja it works :) :) :) :) 👍 👍 👍

@ralphtheninja ralphtheninja deleted the travis branch August 26, 2018 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants