Run tests using greenmail server #98
Conversation
| let dc = null | ||
|
|
||
| test('setUp dc context', t => { | ||
| t.plan(3) | ||
| dc = new DeltaChat({ | ||
| addr: env.DC_ADDR, | ||
| mail_pw: env.DC_MAIL_PW, | ||
| addr: 'delta1@delta.localhost', |
There was a problem hiding this comment.
Since we're not using encrypted environment variables on Travis anymore it means external pull requests should also work since we're no longer required to keep them secret since we're running locally.
| cwd: tempy.directory() | ||
| }) | ||
| dc.once('ready', () => t.pass('ready event fired')) | ||
| dc.on('DC_EVENT_ERROR', (data1, data2) => { | ||
| throw new Error(data1 || data2) |
There was a problem hiding this comment.
This will throw if e.g. the server isn't started. Will update docs later.
|
Now tests are working again so we can continue to implement more tests to improve coverage. |
|
lgtm, however, this does not mean anything since i am neither a travis nor a node expert :) |
You're an IMAP/SMTP expert. The rest is just details :) |
i do not think even that. |
this is true, however :) |
Closes #69, closes #24