update UI if display name changed by a different device #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simon-Laux
commented
Feb 9, 2024
src/renderer/stores/settings.ts
Outdated
| }) | ||
| BackendRemote.on('ConfigSynced', (_accountId, { key }) => { | ||
| } | ||
| // SelfavatarChanged event is deprecated and does not seem to work (neither SelfavatarChanged nor iver the new ConfigSynced) |
There was a problem hiding this comment.
@iequidoo I couldn't get self avatar syncing to work at all in my testing.
If it works and also triggers the ConfigSynced event correctly, then we cn remove the listener for the deprecated SelfavatarChanged event?
Simon-Laux
changed the title
|
selfavatar is not synced by the new config sync system yet, though the pr already exists deltachat/deltachat-core-rust#5158 I'll self review my code and merge it into the account sidebar branch now. Also technically this requires a new core release to work, because there is a bug in the current one, but no api changes so it builds without updating core, so I'd say we don't need to wait for a new core version for this one. |
Simon-Laux
merged commit 60e979f
into
simon/new-multi-account-experience
5 of 7 checks passed
Simon-Laux
deleted the
simon/i3624-react-on-multidevice-displayname-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3624