-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App needs to be restarted to see the new displayname set by other device #3624
Comments
we have a cache/store for some settings in desktop, is there an event when it changes? the cache is there to get core values faster, because it is sync, while the core api is async, though we could probably change the code to have less places that rely on it with the cost that we may have to add some loading delays. |
Unfortunately, no special event is emitted for this. Only |
relying on that event would be rather hacky (naming has only weak link to meaning), but could work, but an event that indicates that some config changed would be even better. |
so @farooqkz listen for Was considering to do it myself, but I don't want to steal your issue this time ;) |
Yes, relying on EDIT: Maybe indeed add some EDIT: Though, for self-avatar we already have |
no. we do not cache config values on mobile, this is not needed, things are fast enough. iirc, not caching is no option as all calls are async on desktop? or did that change meanwhile? |
So, i'm going to add some event like
It will also replace EDIT: But then we're going to have some useless events for e.g. EDIT: How about |
I agree, that would be nice, though value is probably not needed, we can always fetch the newest version of it with a core call.
if we do loading states (or react suspense rendering) for places where it is needed we could avoid caching those, but would need some refactoring and maybe not applicable for all cases where the settings store is used. |
Decided not to add a value, otherwise it would be logged which might not be good for privacy when sharing logs |
Merged the core PR |
Merged another core PR fixing the previous one, now should work |
Notes: in DC Android it works as expected. In DC cli, too. Do we have any cache in Desktop?
The text was updated successfully, but these errors were encountered: