Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message text "wobbling" on hover #3862

Merged
merged 1 commit into from
May 27, 2024

Conversation

WofWca
Copy link
Collaborator

@WofWca WofWca commented May 26, 2024

Introduced in a99910e

Before ("Layer Borders" in dev tools is turned on):

DeltaChat_olXODbGOnE.mp4

Watch the text wobble (it's not just a compression thing).

Does not require a CHANGELOG entry because that commit is unreleased

@Simon-Laux
Copy link
Member

Does not require a CHANGELOG entry because that commit is unreleased

I think it is already released in the test release.

Also would it make sense to put this on another layer with z-index / position absolute or things like that?

@WofWca
Copy link
Collaborator Author

WofWca commented May 27, 2024

I think it is already released in the test release.

Yes. Ok, I'll add then.

Also would it make sense to put this on another layer with z-index / position absolute or things like that?

Not sure. I suspect those are different concepts even. Didn't want to dig too deep and just rolled back.

@WofWca WofWca force-pushed the wofwca/fix-message-text-antialiasing-on-hover branch from 6ef7055 to db6c3e5 Compare May 27, 2024 13:38
@WofWca
Copy link
Collaborator Author

WofWca commented May 27, 2024

Updated the CHANGELOG

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog is at the old release

on non-high DPI devices

Introduced in a99910e
@WofWca WofWca force-pushed the wofwca/fix-message-text-antialiasing-on-hover branch from db6c3e5 to 63350c1 Compare May 27, 2024 14:05
@WofWca
Copy link
Collaborator Author

WofWca commented May 27, 2024

Sorry, didn't notice it

@Simon-Laux Simon-Laux merged commit 3b83a46 into main May 27, 2024
6 of 7 checks passed
@Simon-Laux Simon-Laux deleted the wofwca/fix-message-text-antialiasing-on-hover branch May 27, 2024 14:14
@WofWca WofWca restored the wofwca/fix-message-text-antialiasing-on-hover branch May 27, 2024 14:35
@WofWca WofWca deleted the wofwca/fix-message-text-antialiasing-on-hover branch July 13, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants