-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open poi in organic maps app #1877
Conversation
7543ebb
to
8a5c35f
Compare
Why not open in the default map application that the user has installed? I personally would like to open these in |
this pr is more an experiment, in reality, it is not about opening an external app (which, of course may be better than nothing)
it is just that external apps cannot provide what we want to have with location streaming with reasonable effort. we want some embedded functionality at the end, adding pois, showing tracks, live updates and all that. i fear, we currently do not have resources to dive into the system map api on all different platforms, we are already struggling with mapbox a lot :) also, map data from osm are often better. however, as @Simon-Laux mentioned, there is an already working approach for that in #1912 , idea is to get that on android and maybe desktop as well at some point. it needs some polishing, however, it was quite few effort, compared to what we did for mapbox that time. and, there is the advantage, that the map.xdc can be replaced comparable easily, eg. by google maps, apple maps, maybe peermaps at some point, whatever. and that on all systems. so, i do not think, it makes much sense to invest in this pr |
don't forget that this button then should open the internal leaflet map, we still need it for a smooth user experience.
I personally use this pr, as it is better than nothing and I like to be able to not waste precious bytes on my limited data plan, so I like to be able to use my preferred offline maps app. |
sure, additional buttons, ui, functionality etc. can be considered at any time, there is lots of things missing on all platforms. however, first step is to get a shared thing across platforms at |
using this would avoid having to embed additional data/maps https://developer.apple.com/documentation/mapkit/ |
data/maps are not embedded in #1912 and i am pretty sure, mapkit pod/lib does not add much less overhead than the 50k needed for the solution ready at #1912 not to speak about additional coding effort on three platforms, less flexibility and potentially worse maps (apple uses osm sometimes, but still) ... also note, we currently do not have a single ios fulltime dev (not even halftime :) and there are much more important things to get right on ios :) |
closing stale draft |
Telegram seems to offer opening with other installed apps: https://github.com/TelegramMessenger/Telegram-iOS/blob/ae998eb91ef05dfec5c5fa2dfa3c78371992a482/submodules/OpenInExternalAppUI/Sources/OpenInOptions.swift#L89 apple allows for checking schemes for up to 50 different schemes/apps that were defined in the plist under |
works, but organic maps has some bugs that degrade the experience, read more at https://support.delta.chat/t/allow-to-open-map-points-in-organic-maps/2561
organicmaps/organicmaps#5106
organicmaps/organicmaps#5107