Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open poi in organic maps app #1877

Closed
wants to merge 3 commits into from
Closed

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented May 8, 2023

@dignifiedquire
Copy link
Member

Why not open in the default map application that the user has installed? I personally would like to open these in Apple Maps and not some other map application I don't use.

@Simon-Laux
Copy link
Member Author

Simon-Laux commented Sep 2, 2023

Is there a concept of default applications in iOS for something else than email clients and Browsers?
Or would we need to handle this default selection?

Btw @r10s is currently against it and wants to add the leaflet map instead. #1912

@r10s
Copy link
Member

r10s commented Sep 2, 2023

this pr is more an experiment, in reality, it is not about opening an external app (which, of course may be better than nothing)

Btw @r10s is currently against it and wants to add the leaflet map instead

it is just that external apps cannot provide what we want to have with location streaming with reasonable effort.

we want some embedded functionality at the end, adding pois, showing tracks, live updates and all that.

i fear, we currently do not have resources to dive into the system map api on all different platforms, we are already struggling with mapbox a lot :) also, map data from osm are often better.

however, as @Simon-Laux mentioned, there is an already working approach for that in #1912 , idea is to get that on android and maybe desktop as well at some point. it needs some polishing, however, it was quite few effort, compared to what we did for mapbox that time. and, there is the advantage, that the map.xdc can be replaced comparable easily, eg. by google maps, apple maps, maybe peermaps at some point, whatever. and that on all systems.

so, i do not think, it makes much sense to invest in this pr

@Simon-Laux
Copy link
Member Author

Simon-Laux commented Sep 2, 2023

don't forget that this button then should open the internal leaflet map, we still need it for a smooth user experience.
Also an option to open a point in your preferred mapping app is still very useful, as those map apps have routing and can show you the way to a point. Also often they are also integrated with your car's dashboard.

so, i do not think, it makes much sense to invest in this pr

I personally use this pr, as it is better than nothing and I like to be able to not waste precious bytes on my limited data plan, so I like to be able to use my preferred offline maps app.

@r10s
Copy link
Member

r10s commented Sep 2, 2023

sure, additional buttons, ui, functionality etc. can be considered at any time, there is lots of things missing on all platforms. however, first step is to get a shared thing across platforms at

@dignifiedquire
Copy link
Member

using this would avoid having to embed additional data/maps https://developer.apple.com/documentation/mapkit/

@r10s
Copy link
Member

r10s commented Sep 2, 2023

using this would avoid having to embed additional data/maps https://developer.apple.com/documentation/mapkit/

data/maps are not embedded in #1912

and i am pretty sure, mapkit pod/lib does not add much less overhead than the 50k needed for the solution ready at #1912

not to speak about additional coding effort on three platforms, less flexibility and potentially worse maps (apple uses osm sometimes, but still) ... also note, we currently do not have a single ios fulltime dev (not even halftime :) and there are much more important things to get right on ios :)

@r10s
Copy link
Member

r10s commented Oct 5, 2023

closing stale draft

@r10s r10s closed this Oct 5, 2023
@Simon-Laux
Copy link
Member Author

Telegram seems to offer opening with other installed apps: https://github.com/TelegramMessenger/Telegram-iOS/blob/ae998eb91ef05dfec5c5fa2dfa3c78371992a482/submodules/OpenInExternalAppUI/Sources/OpenInOptions.swift#L89

apple allows for checking schemes for up to 50 different schemes/apps that were defined in the plist under LSApplicationQueriesSchemes. I think this would be a nice addition to the map & context menu when we add the map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants