Add years, minutes, and seconds as expiration times #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpk42
reviewed
Jan 16, 2023
hpk42
reviewed
Jan 16, 2023
missytake
force-pushed
the
missytake/add-seconds-expiration-time
branch
2 times, most recently
from
e3b5fc3
to
d26fdf3
Compare
|
Hm, the test passes locally... I'll investigate. |
|
Uff, seems to be a regression in core105 - it still passed with core101. |
|
Ah, not a regression, but a fix :D the test had a workaround for deltachat/deltachat-core-rust#3650, which is not necessary anymore and causes the test to fail now. Removing it fixes it. I opened a separate PR: #97 |
missytake
force-pushed
the
missytake/add-seconds-expiration-time
branch
from
d26fdf3
to
89a8435
Compare
hpk42
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #77
The main purpose of this PR is handling some cases in which users might add unexpected input - seconds will not have much use in production, as prune() is only executed every 10 minutes. But it's still interesting to keep around, as developers can trigger prune() earlier by restarting mailadm or running
mailadm prunemanually, so it's useful for testing purposes even if we can't guarantee that users are indeed created 10 seconds after their creation if their token is only giving them 10 seconds.