Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue with , in links #13

Closed
Simon-Laux opened this issue Jan 25, 2022 · 1 comment · Fixed by #15
Closed

issue with , in links #13

Simon-Laux opened this issue Jan 25, 2022 · 1 comment · Fixed by #15
Labels
bug Something isn't working

Comments

@Simon-Laux
Copy link
Member

,'s get parsed as part of links, this should not be the case, at-least is there is a space behind the comma.

This issue is similar to the brackets issue #12, also I didn't test other chars like :,;, and . yet.
@Simon-Laux Simon-Laux added the bug Something isn't working label Jan 25, 2022
@Simon-Laux
Copy link
Member Author

probably just say that they can not appear at the end of links, just inside of them, this is what VSCode and others do.

Then the test cases could be:

https://delta.chat,
[Link(https://delta.chat),Text(",")]

https://delta.chat,hi
[Link(https://delta.chat,hi)]

https://delta.chat.
[Link(https://delta.chat),Text(".")]

https://delta.chat/page.hi
[Link(https://delta.chat/page.hi)]

Simon-Laux added a commit that referenced this issue Mar 4, 2022
@Simon-Laux
do not consume ,,.,; or : at end of link
9a7af2f 
closes #13
Simon-Laux added a commit that referenced this issue Mar 4, 2022
@Simon-Laux
do not consume ,,.,; or : at end of link
4c8c498 
closes #13
@Simon-Laux Simon-Laux mentioned this issue Mar 4, 2022
Merged
Simon-Laux added a commit that referenced this issue Mar 4, 2022
@Simon-Laux
Merge pull request #15 from deltachat/do-not-consume-comma-at-end-of-…
e16cf6d 
…link-#13

do not consume `,`,`.`,`;` or `:` at end of link closes #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

do not consume ,,.,; or : at end of link closes #13 deltachat/message-parser
1 participant
@Simon-Laux