issues with links in brackets

[r10s]

typing a link in brackets is not working, eg. sth. as A great chat app (see https://delta.chat/en/)

unfortunately, this is contradictory to deltachat/deltachat-desktop#2238

example ...

A great chat app (see https://delta.chat/en/) vs. https://en.wikipedia.org/wiki/Bracket_(disambiguation)

... markdown on github does it right, also ios (did not test android yet). technically, the second link is wrong afaik, however, in practise we cannot insist on that, these links just exist in masses :)

another bug i found during testing ...

a great chat app (see https://delta.chat) is not linkified at all.

[Jikstra]

So basically not allowing a ')' after '/' if the ')' is the last character?

[r10s]

So basically not allowing a ')' after '/' if the ')' is the last character?

not sure, these things are tricky. i would not rely on /. i would have a look what other implementations are doing here :)

trying to get such things correct "from scratch" is probably a huge pain, issues will pop up over and over.

[Simon-Laux]

maybe also report on https://github.com/deltachat/message-parser/issues with some test cases (text, expected result, actual result)

looks like this could be solved with context awareness, so only consume as many brackets as were opened.
Or an other option would be a pseudo parsing element that parses brackets: delimited('(', many(anyElement), ')'), so that the link cannot eat brackets that are closing other ones. but also delimited is not enough for nested brackets, so we would need to implement a bracket parser ourselves. not sure what the better solution is, anyways the most important thing is that we add these things as unit tests so what ever the code might be doing as long as we have enough tests it has to work.

[r10s]

So basically not allowing a ')' after '/' if the ')' is the last character?

just got a real-life example in the dev chat where the bracket is not directly after a slash ...

for desktop we use "mergable" for this (https://github.com/deltachat/deltachat-desktop/blob/master/.github/mergeable.yml), but it is ...

... renders wrongly in delta chat 1.26.0

[Simon-Laux]

a small update:

• android also has this wrong behaviour
• WhatsApp does it right (they seem to count/match the brackets. as I suggested above)