Skip to content

Commit

Permalink
[Lint] Exclude js and css from EOF fixer
Browse files Browse the repository at this point in the history
- When running pre-commit on all files it is picking up minified js and
  css files. Since prettier will format correctly the source files ignore
  them in end-of-file fixer.
- The template files in web docs can be ignored too.
- Removed the unneeded `pre-commit-hooks` dependency as pre-commit
  resolves that itself.
- Include files fixed by pre-commit.
  • Loading branch information
cas-- committed Oct 5, 2018
1 parent 6cf13d1 commit a8a4fb6
Show file tree
Hide file tree
Showing 14 changed files with 13 additions and 16 deletions.
5 changes: 5 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
exclude: >
(?x)^(
deluge/ui/web/docs/template/.*|
)$
repos:
- repo: https://github.com/ambv/black
rev: 18.9b0
Expand Down Expand Up @@ -29,6 +33,7 @@ repos:
name: Fix Double-quotes
- id: end-of-file-fixer
name: Fix End-of-files
exclude_types: [javascript, css]
- id: mixed-line-ending
name: Fix Line-endings
args: [--fix=auto]
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ I can't connect to the daemon from another machine:

.. |docs| image:: https://readthedocs.org/projects/deluge/badge/?version=develop
:target: https://readthedocs.org/projects/deluge/?badge=develop
:alt: Documentation Status
:alt: Documentation Status
4 changes: 0 additions & 4 deletions deluge/plugins/Label/TODO
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,3 @@
*no client-side validation (could be solved by a ui.aclient exception-plugin)
*expand/arrows in sidebar are disabled to save space, fix the space issue or implement an alternative
*fix and move tracker_host column+status-field to core.




2 changes: 1 addition & 1 deletion docs/source/core/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ The Deluge Core

.. toctree::

DelugeRPC <rpc>
DelugeRPC <rpc>
2 changes: 1 addition & 1 deletion docs/source/core/rpc.rst
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,4 @@ Remote API
----------

.. autoclass:: deluge.__rpcapi.RpcApi
:members:
:members:
2 changes: 1 addition & 1 deletion docs/source/interfaces/console.rst
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Deluge Console UI
=================
=================
2 changes: 1 addition & 1 deletion docs/source/interfaces/gtk.rst
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Deluge GTK UI
=============
=============
2 changes: 1 addition & 1 deletion docs/source/interfaces/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ Interfaces.

Gtk Interface <gtk>
Web Interface <web>
Console Interface <console>
Console Interface <console>
2 changes: 1 addition & 1 deletion docs/source/interfaces/web.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ for information on creating one) you are able to specify which you want to use.
There are 2 ways to enable SSL encryption in the webserver, 1 is to specify it
in your configuration (accessible via the Preferences window). The other is to
add '--ssl' when running the webserver, which will override the configuration
value and enable SSL.
value and enable SSL.
1 change: 0 additions & 1 deletion packaging/osx/deluge.modules
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,3 @@
module="T/Twisted/Twisted-12.3.0.tar.bz2"/>
</distutils>
</moduleset>

1 change: 0 additions & 1 deletion packaging/osx/make-app
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,3 @@ find $LIBDIR/python/deluge-*.egg -name "*.py" -exec rm -f {} \; # Remove source
rm -fr $LIBDIR/pygtk/2.0/*demo*

echo "*** Packaging done:`du -hs $APPDIR | cut -f 1`"

2 changes: 1 addition & 1 deletion packaging/win32/DelugeStart Theme/etc/gtk-2.0/gtkrc
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ style "user-font"
{
font_name="9"
}
widget_class "*" style "user-font"
widget_class "*" style "user-font"
1 change: 0 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ tox
tox-venv
detox
pre-commit
pre-commit-hooks
flake8-blind-except
flake8-builtins
flake8-commas
Expand Down
1 change: 0 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,6 @@ def run(self):
'flake8-mutable',
'flake8-quotes',
'pre-commit',
'pre-commit-hooks',
'pytest',
'detox',
'tox',
Expand Down

0 comments on commit a8a4fb6

Please sign in to comment.