[ConsoleUI] remove deferred being returned after command
#408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `return` statement was added in ece31cf, so it is now being removed. Closes: https://dev.deluge-torrent.org/ticket/3582
cas--
pushed a commit
to cas--/Deluge
that referenced
this pull request
Feb 23, 2023
A `return` statement was added in ece31cf, so it is now being removed. Closes: https://dev.deluge-torrent.org/ticket/3582 Closes: deluge-torrent#408
cas--
pushed a commit
to cas--/Deluge
that referenced
this pull request
Feb 24, 2023
A `return` statement was added in ece31cf, so it is now being removed. Closes: https://dev.deluge-torrent.org/ticket/3582 Closes: deluge-torrent#408
doadin
pushed a commit
to doadin/deluge
that referenced
this pull request
Jun 4, 2024
A `return` statement was added in ece31cf for unit testing to work but this resulted in Deferred printed in console output. Added a test_start entry point to return the required deferreds while removing the return from original start entrypoint. Closes: https://dev.deluge-torrent.org/ticket/3582 Closes: deluge-torrent#408
doadin
pushed a commit
to doadin/deluge
that referenced
this pull request
Sep 21, 2024
A `return` statement was added in ece31cf for unit testing to work but this resulted in Deferred printed in console output. Added a test_start entry point to return the required deferreds while removing the return from original start entrypoint. Closes: https://dev.deluge-torrent.org/ticket/3582 Closes: deluge-torrent#408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
returnstatement was added in ece31cf, so it is now being removed.Closes: https://dev.deluge-torrent.org/ticket/3582