Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting on ; instead of ? #76

Closed
jsumners opened this issue Apr 17, 2018 · 2 comments
Closed

Splitting on ; instead of ? #76

jsumners opened this issue Apr 17, 2018 · 2 comments

Comments

@jsumners
Copy link
Contributor

It looks like some vendors use ; instead of ? to separate the path from the query string. This is wrong per spec:

The query component contains non-hierarchical data that, along with
data in the path component (Section 3.3), serves to identify a
resource within the scope of the URI's scheme and naming authority
(if any). The query component is indicated by the first question
mark ("?") character and terminated by a number sign ("#") character
or by the end of the URI.
https://tools.ietf.org/html/rfc3986#section-3.4

But I can tell you that it is out there. So the following should also look for character code 59 as an initial separator.

if (charCode === 63 || charCode === 35) {

@delvedor
Copy link
Owner

😩

Thank you for pointing out, would you mind send a pr?

jsumners added a commit to jsumners/find-my-way that referenced this issue Apr 17, 2018
delvedor added a commit that referenced this issue Apr 18, 2018
@delvedor
Copy link
Owner

Closed in #77 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants