Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static type checking for deployment config + full verifications #1019

Merged
merged 22 commits into from
May 17, 2024

Conversation

mcclurejt
Copy link
Contributor

@mcclurejt mcclurejt commented May 9, 2024

Resolved Issues

  • Deployment configuration files are now statically type-checked instead of being verified at runtime
  • Deployment configuration types are derived from the contract abis, so breaking contract changes are reflected immediately.
  • Verification works for all contract types.

Description

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can
be removed.

[@jalextowle ]

@coveralls
Copy link
Collaborator

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 9082608483

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.377%

Totals Coverage Status
Change from base Build 9072620755: 0.0%
Covered Lines: 1833
Relevant Lines: 1963

💛 - Coveralls

Copy link

github-actions bot commented May 14, 2024

Hyperdrive Gas Benchmark

Benchmark suite Current: c3bb9fd Previous: 33982bb Deviation Status
addLiquidity: min 33827 gas 33827 gas 0% 🟰
addLiquidity: avg 156638 gas 156187 gas 0.2888% 🚨
addLiquidity: max 428173 gas 428173 gas 0% 🟰
checkpoint: min 40292 gas 40292 gas 0% 🟰
checkpoint: avg 142319 gas 142358 gas -0.0274%
checkpoint: max 253424 gas 253424 gas 0% 🟰
closeLong: min 31361 gas 31361 gas 0% 🟰
closeLong: avg 134554 gas 134534 gas 0.0149% 🚨
closeLong: max 2625796 gas 2625796 gas 0% 🟰
closeShort: min 31349 gas 31349 gas 0% 🟰
closeShort: avg 131155 gas 131111 gas 0.0336% 🚨
closeShort: max 401056 gas 262384 gas 52.8508% 🚨
initialize: min 31371 gas 31371 gas 0% 🟰
initialize: avg 330028 gas 330069 gas -0.0124%
initialize: max 396015 gas 396015 gas 0% 🟰
openLong: min 33370 gas 33370 gas 0% 🟰
openLong: avg 172632 gas 172701 gas -0.0400%
openLong: max 306039 gas 306039 gas 0% 🟰
openShort: min 33936 gas 33936 gas 0% 🟰
openShort: avg 167454 gas 167508 gas -0.0322%
openShort: max 414992 gas 414992 gas 0% 🟰
redeemWithdrawalShares: min 31251 gas 31251 gas 0% 🟰
redeemWithdrawalShares: avg 74179 gas 73902 gas 0.3748% 🚨
redeemWithdrawalShares: max 209214 gas 209214 gas 0% 🟰
removeLiquidity: min 31301 gas 31301 gas 0% 🟰
removeLiquidity: avg 208825 gas 208649 gas 0.0844% 🚨
removeLiquidity: max 403026 gas 403026 gas 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@mcclurejt mcclurejt marked this pull request as ready for review May 16, 2024 15:52
@mcclurejt mcclurejt changed the title Verified Factory (confirmed v1.0.6) static type checking for deployment config May 16, 2024
@mcclurejt mcclurejt changed the title static type checking for deployment config static type checking for deployment config + full verifications May 16, 2024
- move any token setup / approval / mint code to prepare function in config so that these functions aren't called when parsing the configuration
- constructor arg fixes in verify script
tasks/deploy/verify.ts Outdated Show resolved Hide resolved
tasks/deploy/verify.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the comments

@mcclurejt mcclurejt enabled auto-merge May 17, 2024 07:15
@mcclurejt mcclurejt added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 4197f43 May 17, 2024
28 checks passed
@mcclurejt mcclurejt deleted the mcclurejt/new-sepolia branch May 17, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants