-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the deployerCoordinatorManager
role to the HyperdriveFactory
#1022
Merged
jalextowle
merged 2 commits into
main
from
jalextowle/factory/deployer-coordinator-manager
May 13, 2024
Merged
Add the deployerCoordinatorManager
role to the HyperdriveFactory
#1022
jalextowle
merged 2 commits into
main
from
jalextowle/factory/deployer-coordinator-manager
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
requested review from
jrhea,
mcclurejt,
cashd and
sentilesdal
as code owners
May 11, 2024 05:55
Pull Request Test Coverage Report for Build 9067119689Details
💛 - Coveralls |
Hyperdrive Gas Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
mcclurejt
approved these changes
May 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comment suggestion otherwise LGTM
jrhea
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new role to the factory that can add and remove deployer coordinators. This will provide some flexibility to governance on mainnet so that they can avoid timelocks every time a deployer coordinator is added.
Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
.If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can
be removed.
[[Reviewer Name]]
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?token spend?
call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on theaddresses that can be called? It shouldn't be possible to
delegatecall
arbitrary addresses, so the list of possible targets should either be
immutable or tightly controlled by an admin.
nonReentrant
?not a concern or how it's mitigated?
memory variables?
issues?
payable
functions restricted to avoid stuck ether?catch underflows?
Safe
functions are altered, are potential underflows andoverflows caught so that a failure flag can be thrown?
covering the full input space?