The access to the class variables should be done through the class API

demarey · Jul 6, 2020 · 48d9c84 · 48d9c84
1 parent 2c4bdf8
commit 48d9c84
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Commander2/CmCommandGroup.class.st b/src/Commander2/CmCommandGroup.class.st
@@ -131,8 +131,10 @@ CmCommandGroup >> register: aCommandOrGroup before: anotherCommandOrGroup [
 CmCommandGroup >> register: aCommandOrGroup insteadOf: anotherCommandOrGroup [
 	| commandToReplaceIndex |
 	commandToReplaceIndex := self entriesIndexOf: anotherCommandOrGroup.
-	((self commands collect: [:each | each name]) \ { (entries at: commandToReplaceIndex) } includes: aCommandOrGroup name)
+
+	((self commands collect: #name) \ { (entries at: commandToReplaceIndex) } includes: aCommandOrGroup name)
 		ifTrue: [ CmDuplicatedEntryName signalEntryNamed: aCommandOrGroup name ].
+
 	entries at: commandToReplaceIndex put: aCommandOrGroup
 ]
 

diff --git a/src/Shift-ClassInstaller/ShiftClassInstaller.class.st b/src/Shift-ClassInstaller/ShiftClassInstaller.class.st
@@ -231,7 +231,7 @@ ShiftClassInstaller >> migrateClassTo: newClass [
 		(newClass classPool includesKey: oldAssociation key)
 			ifTrue: [ 
 				newAssociation := newClass classPool associationAt: oldAssociation key.
-				newAssociation value: oldAssociation value.
+				newClass classVarNamed: oldAssociation key put: oldAssociation value.
 				newClassVariableBindings add: newAssociation.
 				oldClassVariableBindings add: oldAssociation. ]].