Added Usage API #22
Merged
Added Usage API #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkbonhomme
requested changes
Jan 31, 2017
There was a problem hiding this comment.
Hey @JamesFrost
Thanks a lot for making these changes and adding new features! I left a few comments, can you look into them please?
Best,
Dirk
| return; | ||
| } | ||
|
|
||
| if( typeof body !== 'undefined' ) |
There was a problem hiding this comment.
Please wrap this statement in curly brackets
lib/usage.js
Outdated
| if( typeof body !== 'undefined' ) | ||
| body = JSON.parse( body ); | ||
|
|
||
| if (response.statusCode >= 200 && response.statusCode < 300) cb(null, body); |
There was a problem hiding this comment.
Please wrap this statement in curly brackets
| @@ -2,11 +2,15 @@ var EventEmitter = require('events').EventEmitter, | |||
| JSONParser = require('./JSONParser').JSONParser, | |||
| util = require('util'), | |||
| GnipRules = require('./rules'), | |||
| GnipUsage = require('./usage'), | |||
| GnipSearch = require('./search'), | |||
There was a problem hiding this comment.
It looks like you've documented GnipUsage in the Readme but not GnipSearch?
|
Hey @dirkbonhomme, I've made the changes you've requested. |
dirkbonhomme
approved these changes
Feb 8, 2017
|
Thanks @JamesFrost! I've released your changes as v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple api wrapper for the Usage API.
Handles auth + rate limiting.