Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added matrix_look_at. Added generators for matrices. Added project vector onto vector #1

Merged
merged 2 commits into from
Jun 22, 2015

Conversation

rgozim
Copy link

@rgozim rgozim commented Jun 3, 2015

Added some functionality that was present in cml 1.0 and added a function for projecting a vector onto another vector. This could be helpful in implementing a new orthonormalise function.

Probably could do with some clean up on the comments.

@demianmnave
Copy link
Owner

Awesome, thanks! I'm still getting to know GitHub (and git), so it might take a day or two to get this merged. I also want to put in a couple of unit tests to cover your new code. If you have Boost.UnitTestFramework available, feel free to add whatever tests you'd like. Otherwise, I am happy to add them if you are okay with me doing so.

@rgozim
Copy link
Author

rgozim commented Jun 3, 2015

No problem, there's still lots of things I'd like to try adding, just need to get more familiar with the library. I'll have a look over your test implementations and see if I can add some unit tests of my own.

@demianmnave
Copy link
Owner

Awesome, please get in touch if you have any questions.

Also, which compiler(s) are you currently using?

@demianmnave
Copy link
Owner

Hi Riad, sorry I haven't merged your changes yet. I noticed that you put the new code into matrix/projection.{h,tpp}, but it really belongs in transform.{h,tpp}, so I'm moving the code and adding a couple of tests to boot. You'll see what I've done when you grab the changes on your end.

@demianmnave demianmnave merged commit 311f0c8 into demianmnave:cml2 Jun 22, 2015
@rgozim
Copy link
Author

rgozim commented Jun 23, 2015

No problem Demian. Thanks for implementing the tests. I've been mobbed with work for the past few weeks so I've not had a chance to create them.

Also, I'm using Visual Studio 2015.

@demianmnave
Copy link
Owner

No worries!  And 2015 is on my list to test, but let me know if
  you see anything
  funny happening if you get a chance to play around with my changes.

  Thanks, Demian

On 6/23/2015 5:49 AM, rgozim wrote:


  No problem Demian. Thanks for implementing the tests. I've been
    mobbed with work for the past few weeks so I've not had a chance
    to create them.
  Also, I'm using Visual Studio 2015.
  —
    Reply to this email directly or view
      it on GitHub.

demianmnave pushed a commit that referenced this pull request Sep 10, 2015
Added missing slash to header installation path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants