Add API Metrics Reporting Support to CommonServer #16724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuvalbenshalom @anara123 This was more or less my idea as to how to handle the rate limited requests. We set a new property called |
…-GSB-CommonServer � Conflicts: � Packs/Base/ReleaseNotes/1_18_0.md � Packs/Base/pack_metadata.json � Packs/GoogleSafeBrowsing/pack_metadata.json
amshamah419
commented
Mar 1, 2022
amshamah419
commented
Mar 1, 2022
Packs/GoogleSafeBrowsing/Integrations/GoogleSafeBrowsingV2/GoogleSafeBrowsingV2.py
Outdated
Show resolved
Hide resolved
amshamah419
changed the title
…-GSB-CommonServer � Conflicts: � Packs/UrlScan/Integrations/UrlScan/UrlScan.py � Packs/UrlScan/pack_metadata.json
yuvalbenshalom
requested changes
Mar 8, 2022
Packs/GoogleSafeBrowsing/Integrations/GoogleSafeBrowsingV2/GoogleSafeBrowsingV2.py
Outdated
Show resolved
Hide resolved
anara123
reviewed
Mar 8, 2022
demisto.results([{
'Type': entryTypes['note'],
'ContentsFormat': formats['markdown'],
'Contents': "This is an Error",
'HumanReadable': f"This command returned 60 ratelimit errors",
'ErrorType': "RateLimited",
'APICalls': 60
}])
@anara123 @yuvalbenshalom I have the API Call count working, but we really should think of a way to pretty this up. |
…-GSB-CommonServer
…-GSB-CommonServer
|
This pull request introduces 1 alert when merging 6a5d311 into c0aa406 - view on LGTM.com new alerts:
|
…-GSB-CommonServer � Conflicts: � Packs/Base/ReleaseNotes/1_19_0.md � Packs/Base/pack_metadata.json � Packs/VirusTotal/ReleaseNotes/2_2_1.md
amshamah419
requested review from
michalgold,
altmannyarden and
idovandijk
as code owners
…-GSB-CommonServer
…-GSB-CommonServer
|
@yuvalbenshalom @anara123 Validations fail due to moving UrlScan to Py3, otherwise I believe we are good to go. |
anara123
reviewed
Jun 6, 2022
…-GSB-CommonServer � Conflicts: � Packs/Base/pack_metadata.json
amshamah419
changed the title
|
Link to the unit tests coverage report: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
https://github.com/demisto/etc/issues/32115
Description
This PR adds the rate limit handling to CommonServerPython, UrlScan, and to VirusTotal
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have