Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export to stix bundle bug #20323

Merged
merged 20 commits into from Aug 15, 2022
Merged

Export to stix bundle bug #20323

merged 20 commits into from Aug 15, 2022

Conversation

yucohen
Copy link
Contributor

@yucohen yucohen commented Jul 31, 2022

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

The script failed when trying to export more than one indicator. It failed because the indicators contain a field (score) that is not an original property of a stix indicator, and the Bundle method would fail.

@yucohen yucohen marked this pull request as ready for review August 1, 2022 07:17
Copy link
Contributor

@yaakovi yaakovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test

user_args = demisto.args().get('indicators', 'Unknown')
doubleBackslash = demisto.args().get('doubleBackslash', True)
all_args = {}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove all the spacing? Please restore.

# Conflicts:
#	Packs/CommonScripts/ReleaseNotes/1_7_17.md
#	Packs/CommonScripts/pack_metadata.json
@yucohen
Copy link
Contributor Author

yucohen commented Aug 8, 2022

@ShirleyDenkberg Can someone please take a look at the RN? Thanks!

@yucohen yucohen added bug release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process labels Aug 8, 2022
@ShirleyDenkberg
Copy link
Contributor

@Ni-Knight @yaakovi Doc review completed.

@lgtm-com
Copy link

lgtm-com bot commented Aug 15, 2022

This pull request introduces 1 alert when merging 10aaaa4 into 9198485 - view on LGTM.com

new alerts:

  • 1 for Unused import

@yucohen yucohen merged commit f99bc56 into master Aug 15, 2022
@yucohen yucohen deleted the export_to_stix_bundle_bug branch August 15, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docs-approved release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process
Projects
None yet
4 participants