Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Marketplace Contribution] CrowdStrike Falcon - Content Pack Update #20408

Merged
merged 9 commits into from
Aug 31, 2022
Merged

[Marketplace Contribution] CrowdStrike Falcon - Content Pack Update #20408

merged 9 commits into from
Aug 31, 2022

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@amkoppad

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Aug 4, 2022
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_amkoppad-contrib-CrowdStrikeFalcon August 4, 2022 19:14
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @AradCarmi will very shortly look over your proposed changes.

@AradCarmi
Copy link
Contributor

Hi @amkoppad,
Thank you for contributing!
Apologies for the delay in reviewing your PR, the team will review your code as soon as possible.

Thanks again.

@AradCarmi AradCarmi assigned YuvHayun and unassigned AradCarmi Aug 14, 2022
@AradCarmi AradCarmi requested review from YuvHayun and removed request for AradCarmi August 14, 2022 13:23
YuvHayun
YuvHayun requested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amkoppad, Great work!
Please see my comments below.
Also:

  1. Please review the build errors (most of them should be fixed by the suggested fixes).
  2. Notice that you have conflicts so merge from master and fix them.

Please don't hesitate to contact me with any questions, I'm available both here and via slack.
Thanks again!

Packs/CrowdStrikeFalcon/ReleaseNotes/1_9_0.md Outdated Show resolved Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py Show resolved Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py Show resolved Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py Outdated Show resolved Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py Outdated Show resolved Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.yml Outdated Show resolved Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.yml Outdated Show resolved Hide resolved
@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Aug 18, 2022
@YuvHayun
Copy link
Contributor

@amkoppad Hi, how is it going?
Are you doing well with the fixes? let me know if you need any help.

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@amkoppad
Copy link
Contributor

@YuvHayun I have made all the suggested changes. Please let me know what needs to added more. Thank you.

@YuvHayun YuvHayun removed the pending-contributor The PR is pending the response of its creator label Aug 30, 2022
YuvHayun
YuvHayun requested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @amkoppad, thx for the fixes.
I left minor comments, they should fix the unit tests and validation problems.
Also, please merge from master and solve conflicts.
Thank you.

Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py Outdated Show resolved Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.yml Outdated Show resolved Hide resolved
@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Aug 30, 2022
@YuvHayun
Copy link
Contributor

@amkoppad
I see you merged from master and it fixed the conflicts.
Please notice the rest of my comments.
Also, set the currentVersion key in the pack_metadata to be equal to the RN

@amkoppad
Copy link
Contributor

Hi @YuvHayun I am not using the GitHub cli and demisto-sdk to submit my changes. Instead I am just using the GUI and I am not able to find the pack metadata to make the suggested changes. If you can please guide me here it would be great. Thank you.

@YuvHayun
Copy link
Contributor

Hi @YuvHayun I am not using the GitHub cli and demisto-sdk to submit my changes. Instead I am just using the GUI and I am not able to find the pack metadata to make the suggested changes. If you can please guide me here it would be great. Thank you.

It's a small change - I'll do it myself in the internal PR.
I'm merging this one - thx a lot for your contribution!

@YuvHayun YuvHayun merged commit 727082c into demisto:contrib/xsoar-contrib_amkoppad-contrib-CrowdStrikeFalcon Aug 31, 2022
@content-bot content-bot mentioned this pull request Aug 31, 2022
Merged
3 tasks
YuvHayun added a commit that referenced this pull request Sep 11, 2022
@content-bot @xsoar-bot
@amkoppad @YuvHayun
[Marketplace Contribution] CrowdStrike Falcon - Content Pack Update (#…
292e47b 
…20862)

* [Marketplace Contribution] CrowdStrike Falcon - Content Pack Update (#20408)

* "contribution update to pack "CrowdStrike Falcon""

* Update 1_9_0.md

* Update CrowdStrikeFalcon.py

* Update 1_9_0.md

* Update CrowdStrikeFalcon.yml

* Update CrowdStrikeFalcon.yml

* Update CrowdStrikeFalcon.yml

* Update CrowdStrikeFalcon.py

Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>

* fixes

* added word

* fixes

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
@xsoar-bot xsoar-bot deleted the amkoppad-contrib-CrowdStrikeFalcon branch November 23, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amkoppad amkoppad amkoppad left review comments

@YuvHayun YuvHayun YuvHayun approved these changes

Assignees

@YuvHayun YuvHayun

Labels
Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xsoar-bot @content-bot @AradCarmi @YuvHayun @CLAassistant @amkoppad