Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reliability feeds - 7 #20439

Merged
merged 24 commits into from
Aug 14, 2022
Merged

Conversation

GuyAfik
Copy link
Contributor

@GuyAfik GuyAfik commented Aug 8, 2022

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

link to the issue

Description

add Reliability

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Your contributed PolySwarm pack has been modified on files:

Packs/PolySwarm/Integrations/PolySwarmV2/PolySwarmV2.yml
Packs/PolySwarm/ReleaseNotes/2_0_3.md
Packs/PolySwarm/Integrations/PolySwarmV2/PolySwarmV2.py
Packs/PolySwarm/pack_metadata.json
Please review the changes here

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

Your contributed IP-API pack has been modified on files:

Packs/IP-API/pack_metadata.json
Packs/IP-API/Integrations/IPAPI/IPAPI.yml
Packs/IP-API/Integrations/IPAPI/IPAPI.py
Packs/IP-API/ReleaseNotes/1_0_2.md
Please review the changes here

@GuyAfik GuyAfik changed the title Reliability problematic integrations Update reliability feeds - 7 Aug 8, 2022
Copy link

@mwareman mwareman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mwareman
Copy link

mwareman commented Aug 8, 2022

Thank you!

Intent was to approve changes to IP-API only.

@xsoar-bot
Copy link
Contributor

The following integrations/tests were collected by the CI build but are currently skipped. The collected tests are related to this pull request and might be critical.:

  • EclecticIQ Test - reason: Issue 8821
  • MaxMind Test - reason: Issue 18932.
  • Impossible Traveler - Test - reason: Usage limit reached (Issue 38063)

@GuyAfik GuyAfik added the ForceMerge Forcing the merge of the PR despite the build status label Aug 14, 2022
@GuyAfik
Copy link
Contributor Author

GuyAfik commented Aug 14, 2022

Failing due to:

  1. invalid credentials in Microsoft Defender Advanced Threat Protection - Test
  2. [DO106] - the reason for not updating the docker image is because once updating the polyswarm docker image to the new image with a new poly-swarm SDK version, a lot of unit-tests starting to fail, should be fixed by polyswarm.
  3. The rest of the validations are mostly commands which do not present in the README, context output standards that was already problematic before this PR and complains about skipped integrations

@ShahafBenYakir ShahafBenYakir merged commit edf61b0 into master Aug 14, 2022
@ShahafBenYakir ShahafBenYakir deleted the reliability_problematic_integrations branch August 14, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants