Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deletion in content managment #20700

Merged
merged 44 commits into from Dec 19, 2022
Merged

Add deletion in content managment #20700

merged 44 commits into from Dec 19, 2022

Conversation

DinaMeylakh
Copy link
Contributor

@DinaMeylakh DinaMeylakh commented Aug 22, 2022 •
edited

fixes issue: CIAC-560

@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 1 alert when merging af56861 into c7b3223 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2022

This pull request introduces 1 alert when merging 05508eb into 251a6f5 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 2 alerts when merging 953f2f3 into 51ae35b - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Modification of parameter with default

@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 2 alerts when merging 74e60da into 51ae35b - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Modification of parameter with default

@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 1 alert when merging e9529d4 into 9463a45 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 1 alert when merging 3dd7b23 into f8b4a45 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@DinaMeylakh DinaMeylakh changed the title wip: Add deletion in content managment Add deletion in content managment Oct 18, 2022
@DinaMeylakh DinaMeylakh marked this pull request as ready for review October 18, 2022 12:53
ShahafBenYakir
ShahafBenYakir reviewed Nov 12, 2022
View reviewed changes
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Let's aff docstrings to test (given when then)

Packs/ContentManagement/ReleaseNotes/1_1_4.md Outdated Show resolved Hide resolved
Packs/ContentManagement/Scripts/DeleteContent/DeleteContent.yml Outdated Show resolved Hide resolved
Packs/ContentManagement/Scripts/DeleteContent/README.md Outdated Show resolved Hide resolved
Packs/ContentManagement/Scripts/DeleteContent/DeleteContent.yml Outdated Show resolved Hide resolved
Packs/ContentManagement/Scripts/DeleteContent/DeleteContent.yml Outdated Show resolved Hide resolved
Packs/ContentManagement/Scripts/DeleteContent/DeleteContent.py Outdated Show resolved Hide resolved
Packs/ContentManagement/Scripts/DeleteContent/DeleteContent.py Outdated Show resolved Hide resolved
Packs/ContentManagement/Scripts/DeleteContent/DeleteContent.py Outdated Show resolved Hide resolved
Packs/ContentManagement/Scripts/DeleteContent/DeleteContent.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Nov 13, 2022

This pull request introduces 1 alert when merging 2087fdb into 9567054 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/9763a44a-0919-44bf-8327-45338b9fca12/artifacts/0/artifacts/coverage_report/html/index.html

@DinaMeylakh DinaMeylakh merged commit 13ef285 into master Dec 19, 2022
@DinaMeylakh DinaMeylakh deleted the add_deletion_in_content_managment branch December 19, 2022 08:34
efelmandar pushed a commit that referenced this pull request Jan 4, 2023
@DinaMeylakh @efelmandar
Add deletion in content managment (#20700)
0015cdf
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jan 11, 2023
@DinaMeylakh @xsoar-bot
Add deletion in content managment (demisto#20700)
75f79ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahafBenYakir ShahafBenYakir ShahafBenYakir approved these changes

@adi88d adi88d Awaiting requested review from adi88d

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
3 participants
@DinaMeylakh @xsoar-bot @ShahafBenYakir