Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VirusTotal] Avoid raise an error scanning a url when TLD is invalid #20739

Merged
merged 3 commits into from
Aug 28, 2022
Merged

[VirusTotal] Avoid raise an error scanning a url when TLD is invalid #20739

merged 3 commits into from
Aug 28, 2022

Conversation

danipv
Copy link
Contributor

@danipv danipv commented Aug 23, 2022

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

Demo

Screenshot 2022-08-23 at 14 32 56

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Aug 23, 2022
@content-bot content-bot changed the base branch from master to contrib/VirusTotal_feat/virustotal-url-scan-tld August 23, 2022 14:58
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yaakovi will know he can start review the proposed changes.

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Aug 23, 2022
@ShahafBenYakir
Copy link
Contributor

FYI @edik24

@yaakovi yaakovi added docs-approved pending-contributor The PR is pending the response of its creator labels Aug 24, 2022
Co-authored-by: Shai Yaakovi <30797606+yaakovi@users.noreply.github.com>
@yaakovi yaakovi merged commit bf2f264 into demisto:contrib/VirusTotal_feat/virustotal-url-scan-tld Aug 28, 2022
yaakovi added a commit that referenced this pull request Aug 29, 2022
…20739) (#20799)

* Avoid raise an error scaning a url when TLD is invalid

* lint

* Update Packs/VirusTotal/Integrations/VirusTotalV3/VirusTotalV3.py

Co-authored-by: Shai Yaakovi <30797606+yaakovi@users.noreply.github.com>

Co-authored-by: Shai Yaakovi <30797606+yaakovi@users.noreply.github.com>

Co-authored-by: Daniel Pascual <danielvazquez@google.com>
Co-authored-by: Shai Yaakovi <30797606+yaakovi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Partner pending-contributor The PR is pending the response of its creator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants