Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SentinelOne v2] Improved Fetch-Incidents Usage of Timestamps #20970

Merged
merged 5 commits into from
Sep 22, 2022
Merged

[SentinelOne v2] Improved Fetch-Incidents Usage of Timestamps #20970

merged 5 commits into from
Sep 22, 2022

Conversation

DeanArbel
Copy link
Contributor

Status

  • In Hold - (Waiting for customer confirmation)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-15509

Description

Improved handling of timestamps in fetch-incidents command.

@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/956937d9-5cc3-4baa-815e-e65e050501f4/artifacts/0/artifacts/coverage_report/html/index.html

@DeanArbel DeanArbel marked this pull request as ready for review September 21, 2022 14:18
ilaner
ilaner approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@ilaner ilaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looka good

@DeanArbel DeanArbel merged commit a8390b9 into master Sep 22, 2022
@DeanArbel DeanArbel deleted the da_fix_sentinel_one branch September 22, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasBeilin JasBeilin JasBeilin approved these changes

@ilaner ilaner ilaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DeanArbel @xsoar-bot @JasBeilin @ilaner