Fixed an issue where checking domains raises an error with 'NoneType'… #21270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… object has no attribute 'split'
content-bot
changed the base branch from
master
to
contrib/spearmin10_AutoFocusV2
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know he can start review the proposed changes. |
content-bot
added
Community
Contribution Form Filled
YuvHayun
requested changes
Sep 18, 2022
There was a problem hiding this comment.
Looks great! @spearmin10
Let's add one unit test to test cases where we try to extract a None type and make sure it won't raise an error.
YuvHayun
added
the
pending-contributor
YuvHayun
approved these changes
Sep 18, 2022
YuvHayun
added
the
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/3679914 |
|
@spearmin10 |
11 tasks
YuvHayun
added a commit
that referenced
this pull request
Sep 18, 2022
#21293) * Fixed an issue where checking domains raises an error with 'NoneType'… (#21270) * Fixed an issue where checking domains raises an error with 'NoneType' object has no attribute 'split' * Added a test case for domain * RN fixes Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com> Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… object has no attribute 'split'
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
None
Description
When checking some domains (e.g.
mail16.amadeus.net), it raises an error with'NoneType' object has no attribute 'split'Screenshots
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have