Add new command for querying API KEY quota usage #21652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
changed the base branch from
master
to
contrib/Bala-SecneurX_secneurx_analysis_update
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @esharf will know he can start review the proposed changes. |
content-bot
added
Contribution Form Filled
Bala-SecneurX
force-pushed
the
secneurx_analysis_update
branch
from
7c94af5
to
3fa1eb5
Compare
|
Hi @Bala-SecneurX, thank you for the contribution! Reviewing this PR will be slightly delayed as we are in the midst of the local holiday season. We'll have a look as soon as we're back at work. |
esharf
suggested changes
Oct 19, 2022
Packs/SecneurXAnalysis/Integrations/SecneurXAnalysis/SecneurXAnalysis.py
Outdated
Show resolved
Hide resolved
Packs/SecneurXAnalysis/Integrations/SecneurXAnalysis/SecneurXAnalysis.py
Outdated
Show resolved
Hide resolved
Packs/SecneurXAnalysis/Integrations/SecneurXAnalysis/SecneurXAnalysis.py
Show resolved
Hide resolved
Packs/SecneurXAnalysis/Integrations/SecneurXAnalysis/SecneurXAnalysis.py
Show resolved
Hide resolved
esharf
added
the
pending-contributor
|
Thanks will update
Regards,
Bala
________________________________
From: eli sharf ***@***.***>
Sent: Thursday, October 20, 2022 3:13:36 PM
To: demisto/content ***@***.***>
Cc: Bala-SecneurX ***@***.***>; Mention ***@***.***>
Subject: Re: [demisto/content] Add new command for querying API KEY quota usage (PR #21652)
@esharf commented on this pull request.
________________________________
In Packs/SecneurXAnalysis/Integrations/SecneurXAnalysis/SecneurXAnalysis.py<#21652 (comment)>:
+ reportFileName = taskUuid + reportExtn
+ fileContent = fileResult(reportFileName, response)
+ demisto.results(fileContent)
So please use return_results instead of demisto.results.
—
Reply to this email directly, view it on GitHub<#21652 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZOOSHUQNOHMMB73MIYDQYLWEEH4RANCNFSM6AAAAAARB55SEU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Bala-SecneurX
force-pushed
the
secneurx_analysis_update
branch
from
3fa1eb5
to
aebf5d6
Compare
|
@esharf I have updated all the review comments. Sorry for the delay had some issues with our cortex licensing. |
Bala-SecneurX
force-pushed
the
secneurx_analysis_update
branch
from
aebf5d6
to
f007274
Compare
|
This pull request introduces 1 alert when merging f0072748079a2a2f5c1a3d819fee13ce3a94ec93 into af09de3 - view on LGTM.com new alerts:
|
Bala-SecneurX
force-pushed
the
secneurx_analysis_update
branch
2 times, most recently
from
2275092
to
3e9ca06
Compare
* Add new command to get API KEY quota usage details Signed-off-by: Bala Manoharan <bala@secneurx.com>
Bala-SecneurX
force-pushed
the
secneurx_analysis_update
branch
from
dcba09b
to
b6d9f6b
Compare
|
@esharf Could you please review this PR |
esharf
added
docs-approved
and removed
pending-contributor
esharf
approved these changes
Nov 21, 2022
esharf
merged commit 9ae8313
into
demisto:contrib/Bala-SecneurX_secneurx_analysis_update
7 tasks
esharf
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Add new command to get API KEY quota usage details Signed-off-by: Bala Manoharan <bala@secneurx.com> Signed-off-by: Bala Manoharan <bala@secneurx.com>
esharf
pushed a commit
that referenced
this pull request
Nov 27, 2022
* Add new command to get API KEY quota usage details Signed-off-by: Bala Manoharan <bala@secneurx.com> Signed-off-by: Bala Manoharan <bala@secneurx.com>
esharf
added a commit
that referenced
this pull request
Nov 28, 2022
* Add new command for querying API KEY quota usage (#21652) * Add new command to get API KEY quota usage details Signed-off-by: Bala Manoharan <bala@secneurx.com> Signed-off-by: Bala Manoharan <bala@secneurx.com> * fixed docker image tag * added known_words key to .pack-ignore * fixup! added known_words key to .pack-ignore * fixup! fixup! added known_words key to .pack-ignore Signed-off-by: Bala Manoharan <bala@secneurx.com> Co-authored-by: Bala-SecneurX <106752286+Bala-SecneurX@users.noreply.github.com> Co-authored-by: esharf <57587340+esharf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bala Manoharan bala@secneurx.com
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have