Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Prisma SASE Pack and Integration #22736

Closed
wants to merge 2 commits into from

Conversation

content-bot
Copy link
Collaborator

@content-bot content-bot commented Dec 6, 2022

Original External PR

external pull request

Contributor

@jdplant

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-1536.
related MR: 1575.

Description

Create a new Pack and Integration for Prisma SASE API

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

* fixed secrets whitelist

* Updated PA version in Readme

* fixed formatting in PrismaSASE.py

* Updated secrets ignore file

* Updated example response in readme

* Added address object related commands

* Fixed commit issue

* Update Packs/PrismaSASE/README.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/README.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/.secrets-ignore

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE_description.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE_description.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE_description.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE_description.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE.py

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE.py

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE.py

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* made recommended changes

* integrated recommended changes by XSOAR team

* additional recommended changes

* Deleted the Pipfile and Pipfile.lock files

* Added the Prisma SASE API version to the integration's README.md

* Removed the requests import

* Improved the docstrings, Typing, and added spelling corrections

* Changed the Client's docstring to google docstring format

* Added an exception to get_access_token function

* Updated the docker image + Fixed lint error

* Fixed lint error

* updated readme

* various recommended changes

* various recommended changes

* more recommended changes

* update docker image version

* clean up source-user rule building

* additional cleanup

* updated output descriptions

* Update PrismaSASE.yml

Done.

* Update PrismaSASE.yml

Done.

* Update README.md

Done.

* updated readme

* updated readme and command examples

* added 0 as the expires_in default value

* Replaced the "/sse/config/v1/" string with the CONFIG_URI_PREFIX const

* fixed docstrings and arg names

* Added DEFAULT_LIMIT and DEFAULT_OFFSET consts

* Updated the docker image

* Added TPB to the YML file

* Added TPB to the conf.json

* Format fixes

* - Removed the 'Beta'
- Added PANW tag

* Added JD to the CONTRIBUTORS.json

* Set tsg_id integration parameter as required

* Added the default tsg_id integration parameter to the client

* Fixed unit-test according to the tsg_id change

* re-generated readme

* re-generated readme

* Update README.md

* Added a detailed description for the tsg_id arg

* Removed secrets

* Updated the docker image tag

* fixed readable_output for a few commands

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>
Co-authored-by: ShacharKidor <skidorball@paloaltonetworks.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator labels Dec 6, 2022
@ShacharKidor ShacharKidor removed the request for review from ostolero December 6, 2022 14:25
@ShacharKidor ShacharKidor removed their assignment Dec 6, 2022
@xsoar-bot
Copy link
Contributor

@yucohen yucohen mentioned this pull request Jan 25, 2023
3 tasks
@content-bot content-bot closed this Feb 5, 2023
@content-bot content-bot deleted the contrib/jdplant_jdplant_prisma_sase_pack branch February 5, 2023 00:21
@ShacharKidor
Copy link
Contributor

The content of this PR will be merged in 23615.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved pending-contributor The PR is pending the response of its creator
Projects
None yet
7 participants