Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisma sase new commands #23615

Merged
merged 93 commits into from Feb 7, 2023
Merged

Prisma sase new commands #23615

merged 93 commits into from Feb 7, 2023

Conversation

yucohen
Copy link
Contributor

@yucohen yucohen commented Jan 8, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-1536

Description

Original PR: #22736

jdplant and others added 30 commits December 6, 2022 16:19
* fixed secrets whitelist

* Updated PA version in Readme

* fixed formatting in PrismaSASE.py

* Updated secrets ignore file

* Updated example response in readme

* Added address object related commands

* Fixed commit issue

* Update Packs/PrismaSASE/README.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/README.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/.secrets-ignore

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE_description.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE_description.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE_description.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE_description.md

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE.py

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE.py

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* Update Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE.py

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>

* made recommended changes

* integrated recommended changes by XSOAR team

* additional recommended changes

* Deleted the Pipfile and Pipfile.lock files

* Added the Prisma SASE API version to the integration's README.md

* Removed the requests import

* Improved the docstrings, Typing, and added spelling corrections

* Changed the Client's docstring to google docstring format

* Added an exception to get_access_token function

* Updated the docker image + Fixed lint error

* Fixed lint error

* updated readme

* various recommended changes

* various recommended changes

* more recommended changes

* update docker image version

* clean up source-user rule building

* additional cleanup

* updated output descriptions

* Update PrismaSASE.yml

Done.

* Update PrismaSASE.yml

Done.

* Update README.md

Done.

* updated readme

* updated readme and command examples

* added 0 as the expires_in default value

* Replaced the "/sse/config/v1/" string with the CONFIG_URI_PREFIX const

* fixed docstrings and arg names

* Added DEFAULT_LIMIT and DEFAULT_OFFSET consts

* Updated the docker image

* Added TPB to the YML file

* Added TPB to the conf.json

* Format fixes

* - Removed the 'Beta'
- Added PANW tag

* Added JD to the CONTRIBUTORS.json

* Set tsg_id integration parameter as required

* Added the default tsg_id integration parameter to the client

* Fixed unit-test according to the tsg_id change

* re-generated readme

* re-generated readme

* Update README.md

* Added a detailed description for the tsg_id arg

* Removed secrets

* Updated the docker image tag

* fixed readable_output for a few commands

Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com>
Co-authored-by: ShacharKidor <skidorball@paloaltonetworks.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
…ase_new_commands

# Conflicts:
#	Packs/PrismaSASE/Integrations/PrismaSASE/PrismaSASE.py
@ShirleyDenkberg
Copy link
Contributor

@yucohen

  • See my comments in the yml file
  • After implementing my comments, regenerate the readme.
  • Need a pack readme.
    @DeanArbel @ostolero Doc review completed.

@xsoar-bot
Copy link
Contributor

@yucohen yucohen merged commit dab4186 into master Feb 7, 2023
@yucohen yucohen deleted the prisma_sase_new_commands branch February 7, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants