-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add USER AGENT incident-filed to XSOAR #22990
Merged
MosheEichler
merged 22 commits into
master
from
add_the_skyhigh_incidnet_fileds_to_both_marketplaces
Dec 22, 2022
Merged
add USER AGENT incident-filed to XSOAR #22990
MosheEichler
merged 22 commits into
master
from
add_the_skyhigh_incidnet_fileds_to_both_marketplaces
Dec 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MosheEichler
added
the
release-notes-only
Indicates that this pull request has ONLY release notes to review for documentation process
label
Dec 12, 2022
@dantavori @michalgold @idovandijk RN reviewed. |
MosheEichler
changed the title
add categories incident-filed to XSIAM
add USER AGENT incident-filed to XSOAR
Dec 13, 2022
MosheEichler
requested review from
efelmandar and
tomer-pan
and removed request for
michalgold,
dantavori and
idovandijk
December 13, 2022 13:33
Link to the unit tests coverage report: |
efelmandar
approved these changes
Dec 22, 2022
MosheEichler
deleted the
add_the_skyhigh_incidnet_fileds_to_both_marketplaces
branch
December 22, 2022 10:14
efelmandar
pushed a commit
that referenced
this pull request
Jan 4, 2023
* add categories to XSIAM * fix * rn * categories * Update 3_3_38.md Done. * add user agent * revert * xsoar xpanse * user agent * rn * revert * prefix docker * prefix * rn * rn * typo * fixes * Capital Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Jan 11, 2023
* add categories to XSIAM * fix * rn * categories * Update 3_3_38.md Done. * add user agent * revert * xsoar xpanse * user agent * rn * revert * prefix docker * prefix * rn * rn * typo * fixes * Capital Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs-approved
release-notes-only
Indicates that this pull request has ONLY release notes to review for documentation process
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Added the User Agent incident filed to the XSOAR marketplace since the Skyhihg mapper uses this incident filed in both marketplaces.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have