Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CommonServerPython URL regex to accept defanged colon #23974

Merged
merged 24 commits into from
Feb 2, 2023
Merged

Updating CommonServerPython URL regex to accept defanged colon #23974

merged 24 commits into from
Feb 2, 2023

Conversation

Ni-Knight
Copy link
Contributor

@Ni-Knight Ni-Knight commented Jan 22, 2023 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-20483

Description

Updating CSP regexes to allow defanged colon.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.8.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

yuvalbenshalom
yuvalbenshalom requested changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a the specific case in the tests.

@Ni-Knight
Removed domain regex as its not used, removed tests for it, reorganiz…
e45c467 
…ed tests in indicator auto detect function with a bit more logic.
@Ni-Knight
Merge branch 'master' into da-csp-url-regex
cf50c89 
# Conflicts:
#	Packs/Base/ReleaseNotes/1_31_56.md
@Ni-Knight
RN
80c5afd
@Ni-Knight
Merge branch 'master' into da-csp-url-regex
f17fa8a 
# Conflicts:
#	Packs/Base/ReleaseNotes/1_31_57.md
#	Packs/Base/Scripts/CommonServerPython/CommonServerPython.py
#	Packs/Base/pack_metadata.json
@Ni-Knight
RN
8178f2f
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/ab903557-cfae-46cc-9d1b-2c9fa4934b01/artifacts/0/artifacts/coverage_report/html/index.html

@yuvalbenshalom yuvalbenshalom merged commit 4985f10 into master Feb 2, 2023
@yuvalbenshalom yuvalbenshalom deleted the da-csp-url-regex branch February 2, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvalbenshalom yuvalbenshalom yuvalbenshalom approved these changes

@MLainer1 MLainer1 Awaiting requested review from MLainer1

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ni-Knight @xsoar-bot @yuvalbenshalom