Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O365 case hold policy ciac 3631 #24914

Merged
merged 24 commits into from
Mar 1, 2023
Merged

Conversation

thefrieddan1
Copy link
Contributor

@thefrieddan1 thefrieddan1 commented Feb 27, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-21354

Description

Adding commands to integration. compliance create,get,delete, policy create,get,delete rule create,get,delete.

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

required: false
isArray: false
- name: external_id
description: Case external Id.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Case external Id.
description: Case external ID.

type: String
- name: o365-sc-compliance-case-delete
deprecated: false
description: Removes compliance cases from the Microsoft Purview compliance portal or the Microsoft Purview compliance portal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean (the way is was presented was confusing. This way is much clearer) -
Removes the Microsoft Purview compliance portal or compliance cases from the Microsoft Purview compliance portal.

isArray: false
- name: o365-sc-case-hold-policy-create
deprecated: false
description: Creates new case hold policies in the Microsoft Purview compliance portal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Creates new case hold policies in the Microsoft Purview compliance portal
description: Creates new case hold policies in the Microsoft Purview compliance portal.

required: true
isArray: false
- name: case
description: eDiscovery case, Case Name, Case Identity (GUID value).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear. Do I need to give all these values or any one of them?

- 'false'
outputs:
- contextPath: O365.SecurityAndCompliance.CaseHoldPolicy.Name
description: CaseHoldPolicy name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: CaseHoldPolicy name.
description: Case hold policy name.

description: CaseHoldPolicy name.
type: String
- contextPath: O365.SecurityAndCompliance.CaseHoldPolicy.Workload
description: CaseHoldPolicy workload.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: CaseHoldPolicy workload.
description: Case hold policy workload.

description: CaseHoldPolicy workload.
type: String
- contextPath: O365.SecurityAndCompliance.CaseHoldPolicy.Enabled
description: Is CaseHoldPolicy enabled.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Is CaseHoldPolicy enabled.
description: Is case hold policy enabled.

description: Is CaseHoldPolicy enabled.
type: String
- contextPath: O365.SecurityAndCompliance.CaseHoldPolicy.Mode
description: CaseHoldPolicy mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: CaseHoldPolicy mode.
description: Case hold policy mode.

type: String
- name: o365-sc-case-hold-policy-get
deprecated: false
description: View existing case hold policies in the Microsoft Purview compliance portal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: View existing case hold policies in the Microsoft Purview compliance portal
description: View existing case hold policies in the Microsoft Purview compliance portal.

- 'false'
outputs:
- contextPath: O365.SecurityAndCompliance.CaseHoldPolicy.Name
description: CaseHoldPolicy name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: CaseHoldPolicy name.
description: Case hold policy name.

description: CaseHoldPolicy name.
type: String
- contextPath: O365.SecurityAndCompliance.CaseHoldPolicy.GUID
description: CaseHoldPolicy GUID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: CaseHoldPolicy GUID.
description: Case hold policy GUID.

| **Path** | **Type** | **Description** |
| --- | --- | --- |
| O365.SecurityAndCompliance.CaseHoldRule.Name | String | CaseHoldPolicy name. |
| O365.SecurityAndCompliance.CaseHoldRule.GUID | UUID | CaseHoldRule GUID. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| O365.SecurityAndCompliance.CaseHoldRule.GUID | UUID | CaseHoldRule GUID. |
| O365.SecurityAndCompliance.CaseHoldRule.GUID | UUID | Case hold policy GUID. |

| --- | --- | --- |
| O365.SecurityAndCompliance.CaseHoldRule.Name | String | CaseHoldPolicy name. |
| O365.SecurityAndCompliance.CaseHoldRule.GUID | UUID | CaseHoldRule GUID. |
| O365.SecurityAndCompliance.CaseHoldRule.Enabled | String | Whether CaseHoldRule is enabled. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| O365.SecurityAndCompliance.CaseHoldRule.Enabled | String | Whether CaseHoldRule is enabled. |
| O365.SecurityAndCompliance.CaseHoldRule.Enabled | String | Whether case hold policy is enabled. |

| O365.SecurityAndCompliance.CaseHoldRule.Name | String | CaseHoldPolicy name. |
| O365.SecurityAndCompliance.CaseHoldRule.GUID | UUID | CaseHoldRule GUID. |
| O365.SecurityAndCompliance.CaseHoldRule.Enabled | String | Whether CaseHoldRule is enabled. |
| O365.SecurityAndCompliance.CaseHoldRule.Mode | String | CaseHoldRule mode. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| O365.SecurityAndCompliance.CaseHoldRule.Mode | String | CaseHoldRule mode. |
| O365.SecurityAndCompliance.CaseHoldRule.Mode | String | Case hold policy mode. |


##### O365 - Security And Compliance - Content Search v2

- Added support for the ***compliance-case-create***, ***compliance-case-get*** ***compliance-case-delete***, ***case-hold-policy-create***, ***case-hold-policy-get***, ***case-hold-policy-delete***, ***case-hold-rule-create***, ***case-hold-rule-get*** and ***case-hold-rule-delete*** commands.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added support for the ***compliance-case-create***, ***compliance-case-get*** ***compliance-case-delete***, ***case-hold-policy-create***, ***case-hold-policy-get***, ***case-hold-policy-delete***, ***case-hold-rule-create***, ***case-hold-rule-get*** and ***case-hold-rule-delete*** commands.
Added support for the following commands:
- ***compliance-case-create***
- ***compliance-case-get***
- ***compliance-case-delete***
- ***case-hold-policy-create***
- ***case-hold-policy-get***
- ***case-hold-policy-delete***
- ***case-hold-rule-create***
- ***case-hold-rule-get***
- ***case-hold-rule-delete***

@ShirleyDenkberg
Copy link
Contributor

@thefrieddan1 Doc review completed.

thefrieddan1 and others added 6 commits February 27, 2023 17:15
…ceV2/SecurityAndComplianceV2.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Tech doc review changes.

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Good job

@thefrieddan1 thefrieddan1 merged commit 72d7212 into master Mar 1, 2023
@thefrieddan1 thefrieddan1 deleted the O365_CaseHoldPolicy_CIAC-3631 branch March 1, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants