Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack ask v2 fix #25264

Merged
merged 8 commits into from
Mar 20, 2023
Merged

Slack ask v2 fix #25264

merged 8 commits into from
Mar 20, 2023

Conversation

YuvHayun
Copy link
Contributor

@YuvHayun YuvHayun commented Mar 14, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-21989
XSUP-22028

Description

  • Fixed an issue where the long-running integration attempted to process bot message in some cases.

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Copy link
Contributor

@amshamah419 amshamah419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Just merge the change to the RNs and you're good to go.

@xsoar-bot
Copy link
Contributor

@YuvHayun YuvHayun merged commit ee54147 into master Mar 20, 2023
@YuvHayun YuvHayun deleted the SlackAskV2_fix branch March 20, 2023 16:03
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Mar 21, 2023
* fix

* fixes

* update docker

* fixes

* changes

* update docker
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Mar 22, 2023
* fix

* fixes

* update docker

* fixes

* changes

* update docker
daryakoval added a commit that referenced this pull request Mar 30, 2023
* "pack contribution initial commit"

* pack resubmitted

* pack resubmitted

* pack resubmitted

* Update .secrets-ignore

* delete redundant file (#23520)

* Forcepoint Email Security Mapping (#25368)

* Created pack ForcepointEmailSecurity

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Slack ask v2 fix (#25264)

* fix

* fixes

* update docker

* fixes

* changes

* update docker

* Tanium Threat Response - list alerts fix (#25152)

* tanium threat response list alerts fix

* bump version

* More EDL logs (#25402)

* added logs

* rns

* docker update

* removed redundant with block

* [demistomock] - update demisto.incident docs (#25389)

* [demistomock] - update demisto.incident docs

* Update Tests/demistomock/demistomock.py

Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>

* fix typo

---------

Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>

* [ASM] - Update Cortex ASM Pack README (#25352) (#25406)

* Update readme

* Update grammar from review comments.

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>

* Fix Slack integration logging (#25398)

* Slack integration logging

* release notes

* updated docker

* resolve conflicts

* Abnormal Security Event Collector: ensure the toAddresses returned as list (#25238)

* reordering_the_message

* added test

* added rn

* changed function name and update dockerimage

* Update README.md

* Update pack_metadata.json

* Update pack_metadata.json

* Update pack_metadata.json

* Update Packs/OpenAiChatGPTV3/pack_metadata.json

* Added ChatGPTv3 Integration Manually

* Add files via upload

* Delete Packs/OpenAI/Integrations/OpenAI/OpenAiChatGPTV3 directory

* removing unessary files

* save release notes

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.yml

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update OpenAiChatGPTV3.py

* Update OpenAiChatGPTV3.py

* Updated and tested

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.yml

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* little fixes

* little fixes

* Remove unused import

---------

Co-authored-by: sepaprivate <113604678+sepaprivate@users.noreply.github.com>
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>
Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
Co-authored-by: Darya Koval <dkoval@paloaltonetworks.com>
Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>
daryakoval added a commit that referenced this pull request Mar 30, 2023
* [Marketplace Contribution] OpenAi ChatGPT v3 (#25397)

* "pack contribution initial commit"

* pack resubmitted

* pack resubmitted

* pack resubmitted

* Update .secrets-ignore

* delete redundant file (#23520)

* Forcepoint Email Security Mapping (#25368)

* Created pack ForcepointEmailSecurity

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/ForcepointEmailSecurity/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Slack ask v2 fix (#25264)

* fix

* fixes

* update docker

* fixes

* changes

* update docker

* Tanium Threat Response - list alerts fix (#25152)

* tanium threat response list alerts fix

* bump version

* More EDL logs (#25402)

* added logs

* rns

* docker update

* removed redundant with block

* [demistomock] - update demisto.incident docs (#25389)

* [demistomock] - update demisto.incident docs

* Update Tests/demistomock/demistomock.py

Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>

* fix typo

---------

Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>

* [ASM] - Update Cortex ASM Pack README (#25352) (#25406)

* Update readme

* Update grammar from review comments.

Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>

* Fix Slack integration logging (#25398)

* Slack integration logging

* release notes

* updated docker

* resolve conflicts

* Abnormal Security Event Collector: ensure the toAddresses returned as list (#25238)

* reordering_the_message

* added test

* added rn

* changed function name and update dockerimage

* Update README.md

* Update pack_metadata.json

* Update pack_metadata.json

* Update pack_metadata.json

* Update Packs/OpenAiChatGPTV3/pack_metadata.json

* Added ChatGPTv3 Integration Manually

* Add files via upload

* Delete Packs/OpenAI/Integrations/OpenAI/OpenAiChatGPTV3 directory

* removing unessary files

* save release notes

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.yml

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update OpenAiChatGPTV3.py

* Update OpenAiChatGPTV3.py

* Updated and tested

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.yml

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update Packs/OpenAI/Integrations/OpenAiChatGPTV3/OpenAiChatGPTV3.py

Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* little fixes

* little fixes

* Remove unused import

---------

Co-authored-by: sepaprivate <113604678+sepaprivate@users.noreply.github.com>
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>
Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
Co-authored-by: Darya Koval <dkoval@paloaltonetworks.com>
Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>

* Update OpenAiChatGPTV3.yml

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: sepaprivate <113604678+sepaprivate@users.noreply.github.com>
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com>
Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>
Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
Co-authored-by: Darya Koval <dkoval@paloaltonetworks.com>
Co-authored-by: Darya Koval <72339940+daryakoval@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants