Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freshwork freshservice integration #25768

Merged
merged 34 commits into from Apr 17, 2023
Merged

Freshwork freshservice integration #25768

merged 34 commits into from Apr 17, 2023

Conversation

TalGumi
Copy link
Contributor

@TalGumi TalGumi commented Apr 9, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Apr 9, 2023
@content-bot content-bot changed the base branch from master to contrib/qmasters-ltd_freshwork-freshservice-integration April 9, 2023 12:37
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @samuelFain will know the proposed changes are ready to be reviewed.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Apr 9, 2023
@dantavori dantavori assigned dantavori and efelmandar and unassigned samuelFain Apr 9, 2023
@dantavori dantavori requested review from dantavori and efelmandar and removed request for samuelFain April 9, 2023 13:54
@dantavori dantavori requested review from gal-forer and removed request for dantavori April 9, 2023 13:56
@dantavori dantavori assigned gal-forer and unassigned dantavori Apr 9, 2023
@dansterenson dansterenson removed their request for review April 10, 2023 11:16
gal-forer
gal-forer suggested changes Apr 13, 2023
View reviewed changes
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.py Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.py Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.py Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.py Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.py Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.py Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/README.md Show resolved Hide resolved
@yaakovpraisler yaakovpraisler removed their request for review April 13, 2023 08:23
ShirleyDenkberg
ShirleyDenkberg reviewed Apr 16, 2023
View reviewed changes
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
ShirleyDenkberg
ShirleyDenkberg reviewed Apr 16, 2023
View reviewed changes
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml Outdated Show resolved Hide resolved
TalGumi and others added 7 commits April 16, 2023 17:24
@TalGumi @ShirleyDenkberg
Update Packs/FreshworksFreshservice/Integrations/FreshworksFreshservi…
c76c6cb 
…ce/FreshworksFreshservice.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@TalGumi @ShirleyDenkberg
Update Packs/FreshworksFreshservice/Integrations/FreshworksFreshservi…
620b237 
…ce/FreshworksFreshservice.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@TalGumi @ShirleyDenkberg
Update Packs/FreshworksFreshservice/Integrations/FreshworksFreshservi…
d76b2ed 
…ce/FreshworksFreshservice.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@TalGumi
Change description
b24879a
@TalGumi
Merge branch 'freshwork-freshservice-integration' of https://github.c…
b2f971d 
…om/qmasters-ltd/content into freshwork-freshservice-integration
@TalGumi
Change yml & md
bbb4292
@TalGumi
Merge branch 'contrib/qmasters-ltd_freshwork-freshservice-integration…
44199c8 
…' into freshwork-freshservice-integration
@gal-forer gal-forer merged commit dbc67b3 into demisto:contrib/qmasters-ltd_freshwork-freshservice-integration Apr 17, 2023
15 of 18 checks passed
@content-bot content-bot mentioned this pull request Apr 17, 2023
Merged
11 tasks
gal-forer added a commit that referenced this pull request Apr 19, 2023
@content-bot @TalGumi
@Benimanela @ShirleyDenkberg @gal-forer
Freshwork freshservice integration (#25907)
768103a 
* Freshwork freshservice integration (#25768)

* Update Docker Image To demisto/py3-tools  (#25523)

* Updated Metadata Of Pack FeedAWS

* Added release notes to pack FeedAWS

* Packs/FeedAWS/Integrations/FeedAWS/FeedAWS.yml Docker image update

* Update Freshservice integration

* Update Freshservice integration

* update integration files

* updates

* updates

* Fixing mirroring

* update integration files

* update files acording to validate command

* Update prefix for incident fields

* Update common types

* update last run implemantaion

* update mapper & classifier names

* Update pack metadat name

* Update classifier & mapper & fields prefix name

* updated CommonType release notes

* Update docket image & release notes

* Add to pack_ignore, for some incident fields, error code to ignore.

* add integration README

* put the checkboxes(type 8) at the bottom

* Update Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Change description

* Change yml & md

---------

Co-authored-by: Benimanela <benim@qmasters.co>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Bump pack from version CommonTypes to 3.3.64.

* Added secrets to ignore

* Removed unneeded gitignore file

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/FreshworksFreshservice/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/FreshworksFreshservice/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/FreshworksFreshservice/Integrations/FreshworksFreshservice/FreshworksFreshservice.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Added Shirley's changes to the yml file

* Bump pack from version CommonTypes to 3.3.65.

* Added Shirley's changes to the yml file

* Added test playbook to ignore because we don't have an instance

* Fix incoming mapper name

* Fix incoming mapper name

* Fix incoming mapper name

* Removed nbsp

* Removed nbsp

* Removed nbsp

---------

Co-authored-by: TalGumi <101499620+TalGumi@users.noreply.github.com>
Co-authored-by: Benimanela <benim@qmasters.co>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: gal-forer <gforer@paloaltonetworks.com>
Co-authored-by: gal-forer <forer.gal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@efelmandar efelmandar efelmandar left review comments

@gal-forer gal-forer gal-forer approved these changes

@michalgold michalgold Awaiting requested review from michalgold

@idovandijk idovandijk Awaiting requested review from idovandijk

Assignees

@gal-forer gal-forer

@ShirleyDenkberg ShirleyDenkberg

@efelmandar efelmandar

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome!
Projects
None yet
Milestone
No milestone
8 participants
@TalGumi @content-bot @gal-forer @ShirleyDenkberg @efelmandar @dantavori @samuelFain @Benimanela