Added dynamic configuration for CoreRestApi on Content side #26305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansterenson
changed the title
dansterenson
changed the title
dansterenson
requested review from
ilaner,
dorschw,
daryakoval and
ostolero
as code owners
DeanArbel
reviewed
May 7, 2023
pyproject.toml
Outdated
| @@ -10,7 +10,7 @@ python = "^3.8,<3.11" | |||
| defusedxml = "^0.7.1" | |||
|
|
|||
| [tool.poetry.group.dev.dependencies] | |||
| demisto_sdk = "1.14.0" | |||
| demisto-sdk = {git = "https://github.com/demisto/demisto-sdk.git", rev="789278337995c786e55b80f50c58d6410f70689b"} | |||
There was a problem hiding this comment.
@dansterenson please confirm this action with @dorschw
There was a problem hiding this comment.
do not merge. let's discuss it offline
There was a problem hiding this comment.
It was just for testing. As written, it should be merged after this is merged.
There was a problem hiding this comment.
This file will be reverted once the SDK version is released.
dansterenson
commented
May 7, 2023
pyproject.toml
Outdated
There was a problem hiding this comment.
will revert it after sdk release
pyproject.toml
Outdated
| @@ -10,7 +10,7 @@ python = "^3.8,<3.11" | |||
| defusedxml = "^0.7.1" | |||
|
|
|||
| [tool.poetry.group.dev.dependencies] | |||
| demisto_sdk = "1.14.0" | |||
| demisto-sdk = {git = "https://github.com/demisto/demisto-sdk.git", rev="789278337995c786e55b80f50c58d6410f70689b"} | |||
There was a problem hiding this comment.
It was just for testing. As written, it should be merged after this is merged.
pyproject.toml
Outdated
| @@ -10,7 +10,7 @@ python = "^3.8,<3.11" | |||
| defusedxml = "^0.7.1" | |||
|
|
|||
| [tool.poetry.group.dev.dependencies] | |||
| demisto_sdk = "1.14.0" | |||
| demisto-sdk = {git = "https://github.com/demisto/demisto-sdk.git", rev="789278337995c786e55b80f50c58d6410f70689b"} | |||
There was a problem hiding this comment.
This file will be reverted once the SDK version is released.
# Conflicts: # poetry.lock # pyproject.toml
# Conflicts: # poetry.lock # pyproject.toml
# Conflicts: # Packs/DemistoRESTAPI/ReleaseNotes/1_3_23.md
|
@DeanArbel validation fails on Force merge is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after SDK release with the following PR: demisto/demisto-sdk#2722
Status
Related Issues
https://jira-hq.paloaltonetworks.local/browse/CIAC-6112
https://jira-hq.paloaltonetworks.local/browse/CIAC-528
Minimum version of Cortex XSOAR
Does it break backward compatibility?