Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl credentialize instances #26557

Merged
merged 42 commits into from Jun 15, 2023
Merged

Jl credentialize instances #26557

merged 42 commits into from Jun 15, 2023

Conversation

jlevypaloalto
Copy link
Contributor

@jlevypaloalto jlevypaloalto commented May 16, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: Align Credentials for Google Drive and Cylance Protect v2

Description

Align Credentials for Google Drive and Cylance Protect v2

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@guardrails
Copy link

guardrails bot commented May 17, 2023

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

JudahSchwartz
JudahSchwartz previously approved these changes May 30, 2023
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this tested? Or do we have tpbs?

Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any change required in the READMEs to note the new creds?

@jlevypaloalto jlevypaloalto removed the request for review from Shellyber June 13, 2023 07:23
@jlevypaloalto jlevypaloalto merged commit 7bb2e8e into master Jun 15, 2023
17 checks passed
@jlevypaloalto jlevypaloalto deleted the jl-credentialize-instances branch June 15, 2023 10:35
TalNos pushed a commit that referenced this pull request Jun 16, 2023
* added credtential option to Cylance Protect

* updated release notes

* added error in case of insufficient creds

* fixed bug in error in case of insufficient creds

* added creds as config option

* added hidden to old fields

* updated release notes

* updated docker image

* updated docker image

* updated secrets ignore

* updated secrets ignore again

* updated docker

* Revert "updated secrets ignore"

This reverts commit 5804516.

* revised release notes

* remove pipeline files

* Update 1_2_31.md

* Revert 1_2_31.md to bot version

* Update 1_2_31.md

* Update 1_1_16.md to bot version

* update release notes

* update release notes pylance project

* fixed test errors

* update docker image

* Remove empty ignore from .pack-ignore

* fixed user_id bug

* updated release notes

* fixed precommit errors

* possible solution to server error

* update docker

* updated docker

* updated docker

* Added period to 1_2_33.md

* update docker
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* added credtential option to Cylance Protect

* updated release notes

* added error in case of insufficient creds

* fixed bug in error in case of insufficient creds

* added creds as config option

* added hidden to old fields

* updated release notes

* updated docker image

* updated docker image

* updated secrets ignore

* updated secrets ignore again

* updated docker

* Revert "updated secrets ignore"

This reverts commit 4ea3ea973ab6547ea09b4a73d3445e630b6b5be3.

* revised release notes

* remove pipeline files

* Update 1_2_31.md

* Revert 1_2_31.md to bot version

* Update 1_2_31.md

* Update 1_1_16.md to bot version

* update release notes

* update release notes pylance project

* fixed test errors

* update docker image

* Remove empty ignore from .pack-ignore

* fixed user_id bug

* updated release notes

* fixed precommit errors

* possible solution to server error

* update docker

* updated docker

* updated docker

* Added period to 1_2_33.md

* update docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants