New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jl credentialize instances #26557
Merged
Merged
Jl credentialize instances #26557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlevypaloalto
force-pushed
the
jl-credentialize-instances
branch
from
May 17, 2023 15:06
8b5c363
to
0579e37
Compare
JudahSchwartz
previously approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this tested? Or do we have tpbs?
JudahSchwartz
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any change required in the READMEs to note the new creds?
TalNos
pushed a commit
that referenced
this pull request
Jun 16, 2023
* added credtential option to Cylance Protect * updated release notes * added error in case of insufficient creds * fixed bug in error in case of insufficient creds * added creds as config option * added hidden to old fields * updated release notes * updated docker image * updated docker image * updated secrets ignore * updated secrets ignore again * updated docker * Revert "updated secrets ignore" This reverts commit 5804516. * revised release notes * remove pipeline files * Update 1_2_31.md * Revert 1_2_31.md to bot version * Update 1_2_31.md * Update 1_1_16.md to bot version * update release notes * update release notes pylance project * fixed test errors * update docker image * Remove empty ignore from .pack-ignore * fixed user_id bug * updated release notes * fixed precommit errors * possible solution to server error * update docker * updated docker * updated docker * Added period to 1_2_33.md * update docker
tkatzir
pushed a commit
that referenced
this pull request
Dec 20, 2023
* added credtential option to Cylance Protect * updated release notes * added error in case of insufficient creds * fixed bug in error in case of insufficient creds * added creds as config option * added hidden to old fields * updated release notes * updated docker image * updated docker image * updated secrets ignore * updated secrets ignore again * updated docker * Revert "updated secrets ignore" This reverts commit 4ea3ea973ab6547ea09b4a73d3445e630b6b5be3. * revised release notes * remove pipeline files * Update 1_2_31.md * Revert 1_2_31.md to bot version * Update 1_2_31.md * Update 1_1_16.md to bot version * update release notes * update release notes pylance project * fixed test errors * update docker image * Remove empty ignore from .pack-ignore * fixed user_id bug * updated release notes * fixed precommit errors * possible solution to server error * update docker * updated docker * updated docker * Added period to 1_2_33.md * update docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: Align Credentials for Google Drive and Cylance Protect v2
Description
Align Credentials for Google Drive and Cylance Protect v2
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have