Devo_v2 integration: v1.3.0 release with submitted fixes and pagination tuning #26699

pavel-kalmykov · 2023-05-22T09:21:16Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress (waiting for XSOAR's review).
Ready
In Hold - (Reason for hold)

Related Issues

follow-up of #24747

Description

We received feedback from this integration's users regarding some bugs related to the alert-incident mapping. In addition, we have fine-tuned some pagination parameters, making some of them mandatory, to avoid memory-related issues.

Aside from the integration changes, some additional test cases were added.

Screenshots

Minimum version of Cortex XSOAR

6.0.0
6.1.0
6.2.0
6.5.0

Does it break backward compatibility?

Yes
- Further details: some commands now require you to set the pagination configuration.
No

Must have

Tests
Documentation

…_2_1.md in releaseNotes

…s now a non mandatory param, mdx dependency version bumped dowm, added 1.2.0.md

CLAassistant · 2023-05-22T09:21:22Z

All committers have signed the CLA.

content-bot · 2023-05-22T09:25:11Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @michal-dagan will know the proposed changes are ready to be reviewed.

pavel-kalmykov · 2023-05-22T09:56:24Z

From the comments I found in the CircleCI pipeline, it seems that having breaking changes implies a mandatory MAJOR version bump. Is that correct? I have no issue setting the version to 2.0.0, but I want to be extra sure about that.

michal-dagan

Hi @pavel-razgovorov,
Thank you for your contribution!
Good work!
Please see my comments :)

Packs/Devo/Integrations/Devo_v2/Pipfile

michal-dagan · 2023-05-22T14:28:43Z

Packs/Devo/Integrations/Devo_v2/Devo_v2.yml

@@ -54,24 +53,20 @@ configuration:
    name: fetch_incidents_filters
    type: 12
    required: false
-  - display: Deduplication parameters JSON if required


Are you sure you want to delete this parameter?
This parameter could have been configured in the customer instance and could break his flows.
You can make the parameter hidden in the yaml file, this way it does not break compatibility to users already using the integration. New users configuring the integration will not see the hidden parameter since its hidden.

I am reverting this deletion and adding the hidden: true parameter making it not visible in the UI. Thank you for the recommendation.

Packs/Devo/Integrations/Devo_v2/Devo_v2.yml

michal-dagan · 2023-05-22T14:48:57Z

Packs/Devo/Integrations/Devo_v2/Devo_v2.yml

@@ -159,9 +152,6 @@ script:
          description: Start datetime for the specified query. This argument supports natural language (e.g., 2 day, 3 week), Unix timestamps, Python datetime objects, and string datetimes
        - name: to
          description: End datetime for specified query. If provided must be in same format as "from" argument. This argument is ignored in a date range.
-        - name: limit


why do you want to delete this argument?

I am deleting this argument because it was incorrectly implemented, and we deleted any usages to it in the previous PR. We can restore it, but this argument does nothing at the moment.

Packs/Devo/Integrations/Devo_v2/Devo_v2.yml

Packs/Devo/Integrations/Devo_v2/Devo_v2.py

Now it is set to hidden to avoid its future usage.

Now the default value is "50" to avoid XSOAR terminating the command.

…mmand

pavel-kalmykov · 2023-05-25T12:58:42Z

@michal-dagan I've finished submitting the changes that address your comments, yet I am still found with some validation issues. Could you please recheck and tell me how I can solve them? Thank you beforehand.

michal-dagan

@pavel-razgovorov Great work!
Please see my comments :)
if you decide to keep the Deduplication parameters JSON parameter hidden - please update also the Devo_v2_description accordingly

Packs/Devo/ReleaseNotes/1_3_0.md

Packs/Devo/Integrations/Devo_v2/Devo_v2.py

michal-dagan · 2023-05-28T09:15:38Z

Packs/Devo/Integrations/Devo_v2/Devo_v2.py

+            ), 'Missing key:"value" in fetch_incidents_filters.filters configuration'



since you keep the 'fetch_incidents_deduplication' parameter, please revert these lines:

if FETCH_INCIDENTS_DEDUPE: dedupe_conf = check_type(FETCH_INCIDENTS_DEDUPE, dict) assert isinstance(dedupe_conf["cooldown"], (int, float) ), "Invalid fetch_incidents_deduplication configuration"

I presume this is for those who set it up in previous versions. Am I getting it right? Otherwise, why would we need this code, as this parameter is now hidden and cannot (theoretically) be filled?

michal-dagan · 2023-05-28T09:21:06Z

Packs/Devo/ReleaseNotes/1_3_0.md

+- Added fetch Alerts/Incidents pull from custom Devo tables.
+- Updated the Docker image to: *demisto/devo:1.0.0.61805*.
+- Fixed the issue where the plugin was not able to fetch Alerts/Incidents from Devo tables where contents in          
+  'extraData' contains None or 'null' values.


Consider adding an explanation of why the fetch_incidents_deduplication parameter no longer exists

michal-dagan · 2023-05-28T09:23:45Z

Packs/Devo/Integrations/Devo_v2/Devo_v2.yml

@@ -54,24 +53,26 @@ configuration:
    name: fetch_incidents_filters
    type: 12
    required: false
-  - display: Deduplication parameters JSON if required
+  - display: (deprecated) Deduplication parameters JSON if required


The validation failed on

[ERROR]: Packs/Devo/Integrations/Devo_v2/Devo_v2.yml: [IN135] - The integration display names: ['(deprecated) Deduplication parameters JSON if required'] are invalid, Integration parameters display name should be capitalized and spaced using whitespaces and not underscores ( _ ).

you can delete the "(deprecated)"

Regarding the

[ERROR]: Packs/Devo/Integrations/Devo_v2/Devo_v2.yml: [IN124] - Parameter: "fetch_incidents_deduplication" can't be hidden in all marketplaces. Please either remove the hidden attribute, or replace its value with a list of marketplace names, where you wish it to be hidden.

You can add the validation code (IN124) to the pack_ignore file.
You can see docs and example here

…plication` parameter

…recated parameter

Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com>

…d_changes

… into validated_changes

…d_changes

… into validated_changes

pavel-kalmykov · 2023-05-29T15:31:01Z

@michal-dagan After being able to figure out with your help how to solve some validation errors, I am still found with one that complains about the Pipfile's deletion, which makes total sense to remove. Would you like me to add that error to the ignored ones as well?

michal-dagan · 2023-05-30T07:35:52Z

@michal-dagan After being able to figure out with your help how to solve some validation errors, I am still found with one that complains about the Pipfile's deletion, which makes total sense to remove. Would you like me to add that error to the ignored ones as well?

Unfortunately, this is not an error that can be ignored, we will have to do a force-merge.

michal-dagan

@pavel-razgovorov Great work!!!

Packs/Devo/ReleaseNotes/1_2_1.md

Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com>

content-bot · 2023-05-31T12:29:40Z

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5411061

pavel-kalmykov · 2023-06-02T09:23:46Z

@michal-dagan, may I ask how is the review process going? Is there anything else you would need from our side? I am sorry for bothering you; my team keeps asking me when this will be merged, and I would like to know how far or close we are from publishing this.

Thank you beforehand.

…on tuning (#26699) (#27169) * added validated files with new changes * added validated files with new test cases * added changes to simplify handling of 'null' in extraData and added 1_2_1.md in releaseNotes * added better assert statements to deal with key error, writer_creds is now a non mandatory param, mdx dependency version bumped dowm, added 1.2.0.md * chore: revert non-package-related changes * chore(release): v1.3.0 version bump * feat: additional checks in assertions * refactor(Devo_v2): remove unnecessary Pipfile * fix(Devo_v2): revert `fetch_incidents_deduplication` parameter removal Now it is set to hidden to avoid its future usage. * fix(Devo_v2): revert `fetch_incidents_limit` parameter requirement * fix(Devo_v2): revert `items_per_page` arguments to be optional again Now the default value is "50" to avoid XSOAR terminating the command. * fix(Devo_v2): restore `limit` argument from devo-multi-table-query command * chore(Devo_v2): bump docker image version * fix(Devo_v2): correct f-string interpolation * fix(Devo_v2): correct validation errors for the `fetch_incidents_deduplication` parameter * chore(Devo_v2,release): correct release notes and upcoming version * docs(Devo_v2): remove mentions of "Deduplication parameters JSON" deprecated parameter * fix(Devo_v2): revert to optional `items_per_page` default value in code * fix(Devo_v2): correct errors surged after applying suggestions from PR * fix(Devo_v2): correct .pack-ignore settings * docs(style,Devo_v2): join lines --------- Co-authored-by: Pável Kalmykov Razgovórov <9091619+pavel-razgovorov@users.noreply.github.com> Co-authored-by: Abhijeet kumar <abhijeet.kumar@sacumen.com> Co-authored-by: Abhijeet <94753256+abhijeet-sacumen@users.noreply.github.com> Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com>

…t 6 (#27127) * Align credentials stores for all Cortex Marketplace integrations- part 6 * adding Google BigQuery * rl * change require * removing ignore * cr * required to false * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2.py Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com> * Update ContentManagement Owner (#27171) * St trustart to community (#27184) * Changed pack support * Added release notes for the support change * update setup poetry version to 8 (#27185) * Update Docker Image To demisto/py3-tools (#27146) * Updated Metadata Of Pack Active_Directory_Query * Added release notes to pack Active_Directory_Query * Packs/Active_Directory_Query/Integrations/Active_Directory_Query/Active_Directory_Query.yml Docker image update * Updated Metadata Of Pack FeedAWS * Added release notes to pack FeedAWS * Packs/FeedAWS/Integrations/FeedAWS/FeedAWS.yml Docker image update * Updated Metadata Of Pack Active_Directory_Query * Updated Metadata Of Pack Active_Directory_Query * Ews extension ps1 bug (#27153) * Enables running the ews-message-trace-get command without the sender_address and recipient_address arguments * update RN * comment correction * Devo_v2 integration: v1.3.0 release with submitted fixes and pagination tuning (#26699) (#27169) * added validated files with new changes * added validated files with new test cases * added changes to simplify handling of 'null' in extraData and added 1_2_1.md in releaseNotes * added better assert statements to deal with key error, writer_creds is now a non mandatory param, mdx dependency version bumped dowm, added 1.2.0.md * chore: revert non-package-related changes * chore(release): v1.3.0 version bump * feat: additional checks in assertions * refactor(Devo_v2): remove unnecessary Pipfile * fix(Devo_v2): revert `fetch_incidents_deduplication` parameter removal Now it is set to hidden to avoid its future usage. * fix(Devo_v2): revert `fetch_incidents_limit` parameter requirement * fix(Devo_v2): revert `items_per_page` arguments to be optional again Now the default value is "50" to avoid XSOAR terminating the command. * fix(Devo_v2): restore `limit` argument from devo-multi-table-query command * chore(Devo_v2): bump docker image version * fix(Devo_v2): correct f-string interpolation * fix(Devo_v2): correct validation errors for the `fetch_incidents_deduplication` parameter * chore(Devo_v2,release): correct release notes and upcoming version * docs(Devo_v2): remove mentions of "Deduplication parameters JSON" deprecated parameter * fix(Devo_v2): revert to optional `items_per_page` default value in code * fix(Devo_v2): correct errors surged after applying suggestions from PR * fix(Devo_v2): correct .pack-ignore settings * docs(style,Devo_v2): join lines --------- Co-authored-by: Pável Kalmykov Razgovórov <9091619+pavel-razgovorov@users.noreply.github.com> Co-authored-by: Abhijeet kumar <abhijeet.kumar@sacumen.com> Co-authored-by: Abhijeet <94753256+abhijeet-sacumen@users.noreply.github.com> Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com> * Citrix net scaler adc modeling rules (#27120) * Updated the modeling rules to support more types of logs. * Updated the parsing rule * Updated the parsing rules to support more types of logs. * Added release notes. * Fixed issues with handling null values. (#27199) * Fixed issues with handling null values. (#27031) * Update .devcontainer.json name * Update .devcontainer.json name * Update .devcontainer.json name * Update .devcontainer.json name * update * Updated docker tags * Updated RN * Added README * Updated RN * Update RN * Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com> Co-authored-by: RotemAmit <71597826+RotemAmit@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixed pre-commit error --------- Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com> Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com> Co-authored-by: RotemAmit <71597826+RotemAmit@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Cisco catalyst addfield (#27102) * update modeling rules * update modeling rules * update modeling rules * update modeling rules * update modeling rules * update modeling rules * update modeling rules * update modeling rules * Prisma cloud playbook fix (#27203) * Task 26 - change AWSFQDN to NONAWSFQDN * RN * Prisma Access logout bug (#26700) * Update .devcontainer.json name * fix missing opening tag <multi-tenant> * RN * resolve conflict * revert changes devcontainer.json * version * pre commit * Update Packs/PrismaAccess/ReleaseNotes/2_0_4.md Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> --------- Co-authored-by: gbouzar <gbouzar@users.noreply.github.com> Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> * Prisma cloud playbook fix azure fqdn (#27206) * Task 26 - change AzureFQDN to NONAzureFQDN * RN * PAN-OS tag vs tags bug (#27188) * fix tag to tags in pan-os-list-rules command * RN * unskip DockerHardeningCheck in native ga (#27170) * Update Docker Image To demisto/genericsql (#27211) * Updated Metadata Of Pack GenericSQL * Added release notes to pack GenericSQL * Packs/GenericSQL/Integrations/GenericSQL/GenericSQL.yml Docker image update * Align credentials stores part 8 (#27200) * align cred * add ExceedLMS IAM * Unskipp test playbook (#27193) * unskip the TPB * just fo test * rollback test changes * rollback test changes * Ironscales Event Collector (#26496) * first commit * rns and other requirements * major update * added modeling rules - wip * modeling rules changes * some fixes * Update IronscalesEventCollector_test.py * Update IronscalesEventCollector.yml * added modeling rules to rns * auth fix * Update IronscalesModelingRules.xif * updates in collector * precommit fix * cleaner code * better error handling * demo fixes * leftovers (except fetch_ids param) * removed fetch_ids and more stuff * Update IronscalesModelingRules.xif * Apply suggestions from code review Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> * cr notes * fixes * Update Packs/IronscalesEventCollector/Integrations/IronscalesEventCollector/IronscalesEventCollector.py * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * MOVEit Transfer vulnerability (#27209) * new pack for cve-2023-34362 * fixes * update RN * update RN * fixes * fixes * fixes * secrets ignore * typo in task 74 * revert changes to the MajorBreach pack * update secrets ignore * MacOS Mapping (#27064) * Created a new MacOS pack * Removed image.png * Updated ModelingRules * Update README.md * Updated ModelingRules * Updated README * Update Packs/MacOS/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/MacOS/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/MacOS/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/MacOS/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update README.md --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: evisochek <72695126+evisochek@users.noreply.github.com> * GeneratePassword - JS to python (#27134) * first commit * second commit * bump version * update readme * Update Packs/CommonScripts/ReleaseNotes/1_11_83.md Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> --------- Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> * Update Docker Image To demisto/python3 (#27215) * Updated Metadata Of Pack FeedSOCRadarThreatFeed * Added release notes to pack FeedSOCRadarThreatFeed * Packs/FeedSOCRadarThreatFeed/Integrations/FeedSOCRadarThreatFeed/FeedSOCRadarThreatFeed.yml Docker image update * Updated Metadata Of Pack epo * Added release notes to pack epo * Packs/epo/Integrations/epoV2/epoV2.yml Docker image update * Updated Metadata Of Pack CiscoStealthwatch * Added release notes to pack CiscoStealthwatch * Packs/CiscoStealthwatch/Integrations/CiscoStealthwatch/CiscoStealthwatch.yml Docker image update * Updated Metadata Of Pack Securonix * Added release notes to pack Securonix * Packs/Securonix/Integrations/Securonix/Securonix.yml Docker image update * Updated Metadata Of Pack NetBox * Added release notes to pack NetBox * Packs/NetBox/Integrations/NetBoxEventCollector/NetBoxEventCollector.yml Docker image update * Updated Metadata Of Pack illuminate * Added release notes to pack illuminate * Packs/illuminate/Integrations/Analyst1/Analyst1.yml Docker image update * Updated Metadata Of Pack BmcHelixRemedyForce * Added release notes to pack BmcHelixRemedyForce * Packs/BmcHelixRemedyForce/Integrations/BmcHelixRemedyForce/BmcHelixRemedyForce.yml Docker image update * Updated Metadata Of Pack Rapid7_InsightIDR * Added release notes to pack Rapid7_InsightIDR * Packs/Rapid7_InsightIDR/Integrations/Rapid7_InsightIDR/Rapid7_InsightIDR.yml Docker image update * Updated Metadata Of Pack Zerohack_XDR * Added release notes to pack Zerohack_XDR * Packs/Zerohack_XDR/Integrations/ZerohackXDR/ZerohackXDR.yml Docker image update * Updated Metadata Of Pack XMCyber * Added release notes to pack XMCyber * Packs/XMCyber/Integrations/XMCyberIntegration/XMCyberIntegration.yml Docker image update * Update Docker Image To demisto/pyjwt3 (#27217) * Updated Metadata Of Pack Zoom * Added release notes to pack Zoom * Packs/Zoom/Integrations/Zoom/Zoom.yml Docker image update * Packs/Zoom/Integrations/ZoomEventCollector/ZoomEventCollector.yml Docker image update * Update Docker Image To demisto/btfl-soup (#27219) * Updated Metadata Of Pack Jira * Added release notes to pack Jira * Packs/Jira/Integrations/JiraV3/JiraV3.yml Docker image update * Align credentials stores part 9 (#27201) * Align credentials part 9 * add Telegram * rl * Update Packs/Telegram/Integrations/Telegram/Telegram.py Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com> --------- Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com> * Update Docker Image To demisto/glpi (#27220) * Updated Metadata Of Pack GLPI * Added release notes to pack GLPI * Packs/GLPI/Integrations/GLPI/GLPI.yml Docker image update * Update Docker Image To demisto/python3 (#27210) * Updated Metadata Of Pack Base * Added release notes to pack Base * Packs/Base/Scripts/HighlightWords/HighlightWords.yml Docker image update * Packs/Base/Scripts/GetIndicatorsByQuery/GetIndicatorsByQuery.yml Docker image update * Packs/Base/Scripts/CheckDockerImageAvailable/CheckDockerImageAvailable.yml Docker image update * Packs/Base/Scripts/GetIncidentsByQuery/GetIncidentsByQuery.yml Docker image update * Packs/Base/Scripts/SearchIndicatorRelationships/SearchIndicatorRelationships.yml Docker image update * Fixed validate and lint --------- Co-authored-by: sberman <sberman@paloaltonetworks.com> * Update Docker Image To demisto/fastapi (#27218) * Updated Metadata Of Pack Jira * Added release notes to pack Jira * Packs/Jira/Integrations/JiraEventCollector/JiraEventCollector.yml Docker image update * Bump pack from version Jira to 3.0.2. --------- Co-authored-by: Content Bot <bot@demisto.com> * 1.15.5 (#27065) * Rubrik release 1 2 2 (#26473) (#27223) * Update .devcontainer.json name * Rubrik Polaris Release 1.2.2 * Updated docker image tags * resolving conflict --------- Co-authored-by: Crest Data Systems <60967033+crestdatasystems@users.noreply.github.com> Co-authored-by: crestdatasystems <crestdatasystems@users.noreply.github.com> Co-authored-by: RotemAmit <71597826+RotemAmit@users.noreply.github.com> * Fix ExpanseV2 TPB (#27128) * fixed tpb - removed the check for Domain.DomainStatus isNotEmpty * Add search to open cti (#27189) * added argument * added rn * argument name update * Update Packs/OpenCTI/ReleaseNotes/1_0_7.md Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com> * fixes * fixes * fixes --------- Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com> * Update enabled key in filters and transformers yml (#27187) * Update enabled key in script's yml * Update docker images/release notes * Add missing README files * Bump pack from version FiltersAndTransformers to 1.2.20. --------- Co-authored-by: Content Bot <bot@demisto.com> * Remove default values from yml - phase 1 (#27190) * remove default values from yml - phase 1 * add err to ignore * [TAXII2ApiModule] Fix kwargs argument in function call (#27205) * Fix as_pages kwargs argument in function call * Update RN to packs that using TAXII2ApiModule * Change 'pack' to 'script' in release notes * Apply suggestions from docs review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * CoreRestAPI URL suffix fix (#27227) * fix issue * update RN --------- Co-authored-by: xsoar-bot <xsoar-bot@paloaltonetworks.com> * precommit fix MDX server (#27232) * fix --------- Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com> Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com> Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com> Co-authored-by: Pável Kalmykov Razgovórov <9091619+pavel-razgovorov@users.noreply.github.com> Co-authored-by: Abhijeet kumar <abhijeet.kumar@sacumen.com> Co-authored-by: Abhijeet <94753256+abhijeet-sacumen@users.noreply.github.com> Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com> Co-authored-by: yasta5 <112320333+yasta5@users.noreply.github.com> Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com> Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com> Co-authored-by: RotemAmit <71597826+RotemAmit@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> Co-authored-by: guytamir10 <106061479+guytamir10@users.noreply.github.com> Co-authored-by: Tomer Haimof <81556849+tomer-pan@users.noreply.github.com> Co-authored-by: rshunim <102469772+rshunim@users.noreply.github.com> Co-authored-by: gbouzar <gbouzar@users.noreply.github.com> Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com> Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> Co-authored-by: Ben Melamed <bmelamed@paloaltonetworks.com> Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> Co-authored-by: evisochek <72695126+evisochek@users.noreply.github.com> Co-authored-by: sberman <sberman@paloaltonetworks.com> Co-authored-by: Content Bot <bot@demisto.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> Co-authored-by: Crest Data Systems <60967033+crestdatasystems@users.noreply.github.com> Co-authored-by: crestdatasystems <crestdatasystems@users.noreply.github.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com> Co-authored-by: samuelFain <65926551+samuelFain@users.noreply.github.com> Co-authored-by: Dan Sterenson <38375556+dansterenson@users.noreply.github.com> Co-authored-by: xsoar-bot <xsoar-bot@paloaltonetworks.com>

abhijeet-sacumen and others added 11 commits May 4, 2023 16:57

added validated files with new changes

b12e38d

added validated files with new test cases

b8e4664

Merge branch 'demisto:master' into validated_changes

00789ea

Merge branch 'demisto:master' into validated_changes

80db041

added changes to simplify handling of 'null' in extraData and added 1…

9db2329

…_2_1.md in releaseNotes

Merge branch 'demisto:master' into validated_changes

4addf5b

added better assert statements to deal with key error, writer_creds i…

8c88bd3

…s now a non mandatory param, mdx dependency version bumped dowm, added 1.2.0.md

Merge branch 'demisto:master' into validated_changes

97ecda1

chore: revert non-package-related changes

5cda218

chore(release): v1.3.0 version bump

95fc582

feat: additional checks in assertions

fa1adca

content-bot added Contribution Thank you! Contributions are always welcome! Partner Support Level Indicates that the contribution is for Partner supported pack labels May 22, 2023

content-bot changed the base branch from master to contrib/DevoInc-Integrations-Sacumen_validated_changes May 22, 2023 09:24

content-bot assigned michal-dagan May 22, 2023

content-bot requested a review from michal-dagan May 22, 2023 09:25

content-bot assigned edik24 May 22, 2023

content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels May 22, 2023

michal-dagan reviewed May 23, 2023

View reviewed changes

michal-dagan added the pending-contributor The PR is pending the response of its creator label May 23, 2023

pavel-kalmykov added 6 commits May 24, 2023 11:37

refactor(Devo_v2): remove unnecessary Pipfile

69b4adf

fix(Devo_v2): revert fetch_incidents_deduplication parameter removal

f93eaea

Now it is set to hidden to avoid its future usage.

fix(Devo_v2): revert fetch_incidents_limit parameter requirement

9a735a9

fix(Devo_v2): revert items_per_page arguments to be optional again

28c4e52

Now the default value is "50" to avoid XSOAR terminating the command.

fix(Devo_v2): restore limit argument from devo-multi-table-query co…

05e0fec

…mmand

chore(Devo_v2): bump docker image version

2521149

fix(Devo_v2): correct f-string interpolation

d004431

michal-dagan reviewed May 28, 2023

View reviewed changes

pavel-kalmykov and others added 10 commits May 29, 2023 12:40

fix(Devo_v2): correct validation errors for the `fetch_incidents_dedu…

8165758

…plication` parameter

chore(Devo_v2,release): correct release notes and upcoming version

7322b22

docs(Devo_v2): remove mentions of "Deduplication parameters JSON" dep…

3193870

…recated parameter

fix(Devo_v2): revert to optional items_per_page default value in code

da92311

Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com>

Merge remote-tracking branch 'origin/validated_changes' into validate…

2e93a14

…d_changes

Merge branch 'contrib/DevoInc-Integrations-Sacumen_validated_changes'…

d914003

… into validated_changes

fix(Devo_v2): correct errors surged after applying suggestions from PR

37fdab7

Merge remote-tracking branch 'origin/validated_changes' into validate…

211f170

…d_changes

Merge branch 'contrib/DevoInc-Integrations-Sacumen_validated_changes'…

1b6bc7c

… into validated_changes

fix(Devo_v2): correct .pack-ignore settings

f218d84

michal-dagan reviewed May 30, 2023

View reviewed changes

Packs/Devo/ReleaseNotes/1_2_1.md Outdated Show resolved Hide resolved

michal-dagan added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label May 30, 2023

docs(style,Devo_v2): join lines

f038c8a

Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com>

michal-dagan added docs-approved ForceMerge and removed pending-contributor The PR is pending the response of its creator labels May 30, 2023

michal-dagan approved these changes Jun 4, 2023

View reviewed changes

michal-dagan merged commit bc8ef65 into demisto:contrib/DevoInc-Integrations-Sacumen_validated_changes Jun 4, 2023
11 of 13 checks passed

content-bot mentioned this pull request Jun 4, 2023

Devo_v2 integration: v1.3.0 release with submitted fixes and pagination tuning #27169

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Devo_v2 integration: v1.3.0 release with submitted fixes and pagination tuning #26699

Devo_v2 integration: v1.3.0 release with submitted fixes and pagination tuning #26699

pavel-kalmykov commented May 22, 2023

CLAassistant commented May 22, 2023 •

edited

content-bot commented May 22, 2023

pavel-kalmykov commented May 22, 2023

michal-dagan left a comment

michal-dagan May 22, 2023

pavel-kalmykov May 24, 2023

michal-dagan May 22, 2023

pavel-kalmykov May 25, 2023

pavel-kalmykov commented May 25, 2023

michal-dagan left a comment •

edited

michal-dagan May 28, 2023

pavel-kalmykov May 29, 2023

michal-dagan May 28, 2023

michal-dagan May 28, 2023

michal-dagan May 28, 2023

pavel-kalmykov commented May 29, 2023

michal-dagan commented May 30, 2023

michal-dagan left a comment

content-bot commented May 31, 2023

pavel-kalmykov commented Jun 2, 2023

		), 'Missing key:"value" in fetch_incidents_filters.filters configuration'

Devo_v2 integration: v1.3.0 release with submitted fixes and pagination tuning #26699

Devo_v2 integration: v1.3.0 release with submitted fixes and pagination tuning #26699

Conversation

pavel-kalmykov commented May 22, 2023

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Screenshots

Minimum version of Cortex XSOAR

Does it break backward compatibility?

Must have

CLAassistant commented May 22, 2023 • edited

content-bot commented May 22, 2023

pavel-kalmykov commented May 22, 2023

michal-dagan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavel-kalmykov commented May 25, 2023

michal-dagan left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavel-kalmykov commented May 29, 2023

michal-dagan commented May 30, 2023

michal-dagan left a comment

Choose a reason for hiding this comment

content-bot commented May 31, 2023

pavel-kalmykov commented Jun 2, 2023

CLAassistant commented May 22, 2023 •

edited

michal-dagan left a comment •

edited