New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update enabled key in filters and transformers yml #27187
Merged
samuelFain
merged 8 commits into
master
from
bugfix/XSUP-24753/enabled_false_for_non_deprecated_scripts
Jun 5, 2023
Merged
Update enabled key in filters and transformers yml #27187
samuelFain
merged 8 commits into
master
from
bugfix/XSUP-24753/enabled_false_for_non_deprecated_scripts
Jun 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelFain
changed the title
Update enabled key in script's yml
Update enabled key in filters and transformers yml
Jun 4, 2023
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
ShacharKidor
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I would have changed the RN note to something like -
'Fixed an issue where the <script's name> script was disabled although it was not deprecated or EOL.
samuelFain
deleted the
bugfix/XSUP-24753/enabled_false_for_non_deprecated_scripts
branch
June 5, 2023 11:46
maimorag
pushed a commit
that referenced
this pull request
Jun 6, 2023
* Update enabled key in script's yml * Update docker images/release notes * Add missing README files * Bump pack from version FiltersAndTransformers to 1.2.20. --------- Co-authored-by: Content Bot <bot@demisto.com>
maimorag
added a commit
that referenced
this pull request
Jun 6, 2023
…t 6 (#27127) * Align credentials stores for all Cortex Marketplace integrations- part 6 * adding Google BigQuery * rl * change require * removing ignore * cr * required to false * Update Packs/CrowdStrikeFalconStreamingV2/Integrations/CrowdStrikeFalconStreamingV2/CrowdStrikeFalconStreamingV2.py Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com> * Update ContentManagement Owner (#27171) * St trustart to community (#27184) * Changed pack support * Added release notes for the support change * update setup poetry version to 8 (#27185) * Update Docker Image To demisto/py3-tools (#27146) * Updated Metadata Of Pack Active_Directory_Query * Added release notes to pack Active_Directory_Query * Packs/Active_Directory_Query/Integrations/Active_Directory_Query/Active_Directory_Query.yml Docker image update * Updated Metadata Of Pack FeedAWS * Added release notes to pack FeedAWS * Packs/FeedAWS/Integrations/FeedAWS/FeedAWS.yml Docker image update * Updated Metadata Of Pack Active_Directory_Query * Updated Metadata Of Pack Active_Directory_Query * Ews extension ps1 bug (#27153) * Enables running the ews-message-trace-get command without the sender_address and recipient_address arguments * update RN * comment correction * Devo_v2 integration: v1.3.0 release with submitted fixes and pagination tuning (#26699) (#27169) * added validated files with new changes * added validated files with new test cases * added changes to simplify handling of 'null' in extraData and added 1_2_1.md in releaseNotes * added better assert statements to deal with key error, writer_creds is now a non mandatory param, mdx dependency version bumped dowm, added 1.2.0.md * chore: revert non-package-related changes * chore(release): v1.3.0 version bump * feat: additional checks in assertions * refactor(Devo_v2): remove unnecessary Pipfile * fix(Devo_v2): revert `fetch_incidents_deduplication` parameter removal Now it is set to hidden to avoid its future usage. * fix(Devo_v2): revert `fetch_incidents_limit` parameter requirement * fix(Devo_v2): revert `items_per_page` arguments to be optional again Now the default value is "50" to avoid XSOAR terminating the command. * fix(Devo_v2): restore `limit` argument from devo-multi-table-query command * chore(Devo_v2): bump docker image version * fix(Devo_v2): correct f-string interpolation * fix(Devo_v2): correct validation errors for the `fetch_incidents_deduplication` parameter * chore(Devo_v2,release): correct release notes and upcoming version * docs(Devo_v2): remove mentions of "Deduplication parameters JSON" deprecated parameter * fix(Devo_v2): revert to optional `items_per_page` default value in code * fix(Devo_v2): correct errors surged after applying suggestions from PR * fix(Devo_v2): correct .pack-ignore settings * docs(style,Devo_v2): join lines --------- Co-authored-by: Pável Kalmykov Razgovórov <9091619+pavel-razgovorov@users.noreply.github.com> Co-authored-by: Abhijeet kumar <abhijeet.kumar@sacumen.com> Co-authored-by: Abhijeet <94753256+abhijeet-sacumen@users.noreply.github.com> Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com> * Citrix net scaler adc modeling rules (#27120) * Updated the modeling rules to support more types of logs. * Updated the parsing rule * Updated the parsing rules to support more types of logs. * Added release notes. * Fixed issues with handling null values. (#27199) * Fixed issues with handling null values. (#27031) * Update .devcontainer.json name * Update .devcontainer.json name * Update .devcontainer.json name * Update .devcontainer.json name * update * Updated docker tags * Updated RN * Added README * Updated RN * Update RN * Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/FiltersAndTransformers/ReleaseNotes/1_2_19.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com> Co-authored-by: RotemAmit <71597826+RotemAmit@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixed pre-commit error --------- Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com> Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com> Co-authored-by: RotemAmit <71597826+RotemAmit@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> * Cisco catalyst addfield (#27102) * update modeling rules * update modeling rules * update modeling rules * update modeling rules * update modeling rules * update modeling rules * update modeling rules * update modeling rules * Prisma cloud playbook fix (#27203) * Task 26 - change AWSFQDN to NONAWSFQDN * RN * Prisma Access logout bug (#26700) * Update .devcontainer.json name * fix missing opening tag <multi-tenant> * RN * resolve conflict * revert changes devcontainer.json * version * pre commit * Update Packs/PrismaAccess/ReleaseNotes/2_0_4.md Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> --------- Co-authored-by: gbouzar <gbouzar@users.noreply.github.com> Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> * Prisma cloud playbook fix azure fqdn (#27206) * Task 26 - change AzureFQDN to NONAzureFQDN * RN * PAN-OS tag vs tags bug (#27188) * fix tag to tags in pan-os-list-rules command * RN * unskip DockerHardeningCheck in native ga (#27170) * Update Docker Image To demisto/genericsql (#27211) * Updated Metadata Of Pack GenericSQL * Added release notes to pack GenericSQL * Packs/GenericSQL/Integrations/GenericSQL/GenericSQL.yml Docker image update * Align credentials stores part 8 (#27200) * align cred * add ExceedLMS IAM * Unskipp test playbook (#27193) * unskip the TPB * just fo test * rollback test changes * rollback test changes * Ironscales Event Collector (#26496) * first commit * rns and other requirements * major update * added modeling rules - wip * modeling rules changes * some fixes * Update IronscalesEventCollector_test.py * Update IronscalesEventCollector.yml * added modeling rules to rns * auth fix * Update IronscalesModelingRules.xif * updates in collector * precommit fix * cleaner code * better error handling * demo fixes * leftovers (except fetch_ids param) * removed fetch_ids and more stuff * Update IronscalesModelingRules.xif * Apply suggestions from code review Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> * cr notes * fixes * Update Packs/IronscalesEventCollector/Integrations/IronscalesEventCollector/IronscalesEventCollector.py * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * MOVEit Transfer vulnerability (#27209) * new pack for cve-2023-34362 * fixes * update RN * update RN * fixes * fixes * fixes * secrets ignore * typo in task 74 * revert changes to the MajorBreach pack * update secrets ignore * MacOS Mapping (#27064) * Created a new MacOS pack * Removed image.png * Updated ModelingRules * Update README.md * Updated ModelingRules * Updated README * Update Packs/MacOS/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/MacOS/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/MacOS/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/MacOS/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update README.md --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: evisochek <72695126+evisochek@users.noreply.github.com> * GeneratePassword - JS to python (#27134) * first commit * second commit * bump version * update readme * Update Packs/CommonScripts/ReleaseNotes/1_11_83.md Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> --------- Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> * Update Docker Image To demisto/python3 (#27215) * Updated Metadata Of Pack FeedSOCRadarThreatFeed * Added release notes to pack FeedSOCRadarThreatFeed * Packs/FeedSOCRadarThreatFeed/Integrations/FeedSOCRadarThreatFeed/FeedSOCRadarThreatFeed.yml Docker image update * Updated Metadata Of Pack epo * Added release notes to pack epo * Packs/epo/Integrations/epoV2/epoV2.yml Docker image update * Updated Metadata Of Pack CiscoStealthwatch * Added release notes to pack CiscoStealthwatch * Packs/CiscoStealthwatch/Integrations/CiscoStealthwatch/CiscoStealthwatch.yml Docker image update * Updated Metadata Of Pack Securonix * Added release notes to pack Securonix * Packs/Securonix/Integrations/Securonix/Securonix.yml Docker image update * Updated Metadata Of Pack NetBox * Added release notes to pack NetBox * Packs/NetBox/Integrations/NetBoxEventCollector/NetBoxEventCollector.yml Docker image update * Updated Metadata Of Pack illuminate * Added release notes to pack illuminate * Packs/illuminate/Integrations/Analyst1/Analyst1.yml Docker image update * Updated Metadata Of Pack BmcHelixRemedyForce * Added release notes to pack BmcHelixRemedyForce * Packs/BmcHelixRemedyForce/Integrations/BmcHelixRemedyForce/BmcHelixRemedyForce.yml Docker image update * Updated Metadata Of Pack Rapid7_InsightIDR * Added release notes to pack Rapid7_InsightIDR * Packs/Rapid7_InsightIDR/Integrations/Rapid7_InsightIDR/Rapid7_InsightIDR.yml Docker image update * Updated Metadata Of Pack Zerohack_XDR * Added release notes to pack Zerohack_XDR * Packs/Zerohack_XDR/Integrations/ZerohackXDR/ZerohackXDR.yml Docker image update * Updated Metadata Of Pack XMCyber * Added release notes to pack XMCyber * Packs/XMCyber/Integrations/XMCyberIntegration/XMCyberIntegration.yml Docker image update * Update Docker Image To demisto/pyjwt3 (#27217) * Updated Metadata Of Pack Zoom * Added release notes to pack Zoom * Packs/Zoom/Integrations/Zoom/Zoom.yml Docker image update * Packs/Zoom/Integrations/ZoomEventCollector/ZoomEventCollector.yml Docker image update * Update Docker Image To demisto/btfl-soup (#27219) * Updated Metadata Of Pack Jira * Added release notes to pack Jira * Packs/Jira/Integrations/JiraV3/JiraV3.yml Docker image update * Align credentials stores part 9 (#27201) * Align credentials part 9 * add Telegram * rl * Update Packs/Telegram/Integrations/Telegram/Telegram.py Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com> --------- Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com> * Update Docker Image To demisto/glpi (#27220) * Updated Metadata Of Pack GLPI * Added release notes to pack GLPI * Packs/GLPI/Integrations/GLPI/GLPI.yml Docker image update * Update Docker Image To demisto/python3 (#27210) * Updated Metadata Of Pack Base * Added release notes to pack Base * Packs/Base/Scripts/HighlightWords/HighlightWords.yml Docker image update * Packs/Base/Scripts/GetIndicatorsByQuery/GetIndicatorsByQuery.yml Docker image update * Packs/Base/Scripts/CheckDockerImageAvailable/CheckDockerImageAvailable.yml Docker image update * Packs/Base/Scripts/GetIncidentsByQuery/GetIncidentsByQuery.yml Docker image update * Packs/Base/Scripts/SearchIndicatorRelationships/SearchIndicatorRelationships.yml Docker image update * Fixed validate and lint --------- Co-authored-by: sberman <sberman@paloaltonetworks.com> * Update Docker Image To demisto/fastapi (#27218) * Updated Metadata Of Pack Jira * Added release notes to pack Jira * Packs/Jira/Integrations/JiraEventCollector/JiraEventCollector.yml Docker image update * Bump pack from version Jira to 3.0.2. --------- Co-authored-by: Content Bot <bot@demisto.com> * 1.15.5 (#27065) * Rubrik release 1 2 2 (#26473) (#27223) * Update .devcontainer.json name * Rubrik Polaris Release 1.2.2 * Updated docker image tags * resolving conflict --------- Co-authored-by: Crest Data Systems <60967033+crestdatasystems@users.noreply.github.com> Co-authored-by: crestdatasystems <crestdatasystems@users.noreply.github.com> Co-authored-by: RotemAmit <71597826+RotemAmit@users.noreply.github.com> * Fix ExpanseV2 TPB (#27128) * fixed tpb - removed the check for Domain.DomainStatus isNotEmpty * Add search to open cti (#27189) * added argument * added rn * argument name update * Update Packs/OpenCTI/ReleaseNotes/1_0_7.md Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com> * fixes * fixes * fixes --------- Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com> * Update enabled key in filters and transformers yml (#27187) * Update enabled key in script's yml * Update docker images/release notes * Add missing README files * Bump pack from version FiltersAndTransformers to 1.2.20. --------- Co-authored-by: Content Bot <bot@demisto.com> * Remove default values from yml - phase 1 (#27190) * remove default values from yml - phase 1 * add err to ignore * [TAXII2ApiModule] Fix kwargs argument in function call (#27205) * Fix as_pages kwargs argument in function call * Update RN to packs that using TAXII2ApiModule * Change 'pack' to 'script' in release notes * Apply suggestions from docs review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * CoreRestAPI URL suffix fix (#27227) * fix issue * update RN --------- Co-authored-by: xsoar-bot <xsoar-bot@paloaltonetworks.com> * precommit fix MDX server (#27232) * fix --------- Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com> Co-authored-by: Menachem Weinfeld <90556466+mmhw@users.noreply.github.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> Co-authored-by: content-bot <55035720+content-bot@users.noreply.github.com> Co-authored-by: israelpoli <72099621+israelpoli@users.noreply.github.com> Co-authored-by: Pável Kalmykov Razgovórov <9091619+pavel-razgovorov@users.noreply.github.com> Co-authored-by: Abhijeet kumar <abhijeet.kumar@sacumen.com> Co-authored-by: Abhijeet <94753256+abhijeet-sacumen@users.noreply.github.com> Co-authored-by: michal-dagan <109464765+michal-dagan@users.noreply.github.com> Co-authored-by: yasta5 <112320333+yasta5@users.noreply.github.com> Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com> Co-authored-by: spearmin10 <spearmin10@users.noreply.github.com> Co-authored-by: RotemAmit <71597826+RotemAmit@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: RotemAmit <ramit@paloaltonetworks.com> Co-authored-by: guytamir10 <106061479+guytamir10@users.noreply.github.com> Co-authored-by: Tomer Haimof <81556849+tomer-pan@users.noreply.github.com> Co-authored-by: rshunim <102469772+rshunim@users.noreply.github.com> Co-authored-by: gbouzar <gbouzar@users.noreply.github.com> Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com> Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com> Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com> Co-authored-by: Ben Melamed <bmelamed@paloaltonetworks.com> Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> Co-authored-by: evisochek <72695126+evisochek@users.noreply.github.com> Co-authored-by: sberman <sberman@paloaltonetworks.com> Co-authored-by: Content Bot <bot@demisto.com> Co-authored-by: ilaner <88267954+ilaner@users.noreply.github.com> Co-authored-by: Crest Data Systems <60967033+crestdatasystems@users.noreply.github.com> Co-authored-by: crestdatasystems <crestdatasystems@users.noreply.github.com> Co-authored-by: Yuval Hayun <70104171+YuvHayun@users.noreply.github.com> Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com> Co-authored-by: samuelFain <65926551+samuelFain@users.noreply.github.com> Co-authored-by: Dan Sterenson <38375556+dansterenson@users.noreply.github.com> Co-authored-by: xsoar-bot <xsoar-bot@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: XSUP-24753
Description
This PR will fix the issue where a few transformers and filters scripts have their yml key set:
enabled: false
even though they are not deprecated or EOL.Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have