remove zoom-send-message foramt arguments #28042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalbenshalom
requested changes
Jul 11, 2023
Packs/Zoom/Integrations/Zoom/Zoom.py
Outdated
Comment on lines
1528
to
1529
| limit = arg_to_number(args.get('limit', 50)) | ||
| page_size = limit if limit and limit <= 50 else 50 | ||
| page_size = args.get('page_size') |
There was a problem hiding this comment.
I did not understand why this change was made. is limit even used?
Packs/Zoom/ReleaseNotes/1_5_1.md
Outdated
|
|
||
| ##### Zoom | ||
|
|
||
| - Updated the zoom-send-message command |
There was a problem hiding this comment.
here we need to add braking changes disclaimer.
Suggested change
| - Updated the zoom-send-message command | |
| - **Breaking changes**: The following arguments were removed from ***zoom-send-message*** command, please use markdown in order to create formatted meseges: | |
| - ***start_position*** | |
| - ***end_position*** | |
| - ***rt_start_position*** | |
| - ***rt_end_position*** | |
| - ***format_type*** | |
| - ***format_attr*** |
yuvalbenshalom
approved these changes
Jul 11, 2023
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* remove zoom-send-message foramt arguments * update release note * fix page_size * f * breakingChanges json * remove json
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Aug 2, 2023
* remove zoom-send-message foramt arguments * update release note * fix page_size * f * breakingChanges json * remove json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
remove message format arguments from zoom-send-message command