[Marketplace Contribution] Atlassian Jira - Content Pack Update #29838

xsoar-bot · 2023-09-25T14:42:54Z

Warning
The changes in the contributed files were not made on the most updated pack versions

Item Name Contribution Pack Version Latest Pack Version

Jira V3 1.2.3 3.1.2

For the Reviewer:

Compare the code of this PR with the latest version of the pack. Make sure you understand the changes the contributor intended to contribute, and solve the conflicts accordingly.

In case improvements are needed, instruct the contributor to edit the code through the GitHub Codespaces and Not through the XSOAR UI.

For the Contributor:
@68zuhKQfKPk
In case you are requested by your reviewer to improve the code or to make changes, submit them through the GitHub Codespaces and Not through the XSOAR UI.

To use the GitHub Codespaces, do the following:

Click the 'Code' button in the right upper corner of this PR.

Click 'Create codespace on Transformers'.

Click 'Authorize and continue'.

Wait until your Codespace environment is generated. When it is, you can edit your code.

Commit and push your changes to the head branch of the PR.

Status

In Progress
Ready
In Hold - (Reason for hold)

Contributor

@68zuhKQfKPk

Notes

Restores the functionality of assigning the user without the need of edit permissions on issues as described in API docs: https://docs.atlassian.com/software/jira/docs/api/REST/9.11.0/#api/2/issue-assign

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

content-bot · 2023-09-25T14:45:31Z

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @ostolero will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

…68zuhKQfKPk-contrib-Jira-1

68zuhKQfKPk · 2023-09-29T09:44:50Z

Small comment regarding this PR:

Currently it is possible to modify the assignee using jira-edit-issue command, but this command is not sufficient for the Jira configurations where user has permission to change the assignee, but can't modify the issue fields.

jira-edit-issue command uses API endpoint which requires permission to edit issue fields
re-introduced jira-issue-assign command (was available in the JiraV2 integration) uses /assignee API endoint which doesn't require edit fields permission

Btw this command were already implemented in the JiraV2, but for some unknown reason weren't migrated: #26087

anas-yousef · 2023-10-02T11:50:35Z

Packs/Jira/Integrations/JiraV3/JiraV3.py

+            method='PUT',
+            url_suffix=f'rest/api/{self.api_version}/issue/{issue_id_or_key}/assignee',
+            json_data=assignee_body,
+            resp_type="text"


According to the Cloud Documentation, the response body is empty, therefore, I believe this should be resp_type='response'

Packs/Jira/ReleaseNotes/3_2_0.md

omerKarkKatz · 2023-10-02T12:52:56Z

Packs/Jira/Integrations/JiraV3/JiraV3.yml

@@ -498,6 +503,63 @@ script:
    - contextPath: Ticket.LastUpdate
      description: The last time the ticket was updated.
      type: Date
+  - arguments:
+    - description: Deprecated. Please use issue_id or issue_key.


Why did you enter this deprecated hidden parameter.
If you copied it from V2 then it was probably in the yml file, only to prevent breaking backward computability this can be removed from this V3 version.

It is actually required, since this argument is already used in JiraV2, and playbooks can be using the issueId argument, upgrading to JiraV3 can break their playbooks if we remove this argument, therefore, it is required to keep it, and mark it as hidden. We map JiraV2 arguments to JiraV3 in the code, using the map_v2_args_to_v3 function

Packs/Jira/Integrations/JiraV3/JiraV3.py

Packs/Jira/Integrations/JiraV3/JiraV3.yml

Packs/Jira/Integrations/JiraV3/README.md

anas-yousef · 2023-10-02T14:41:21Z

Packs/Jira/pack_metadata.json

@@ -2,7 +2,7 @@
    "name": "Atlassian Jira",
    "description": "Use the Jira integration to manage issues and create Cortex XSOAR incidents from Jira projects.",
    "support": "xsoar",
-    "currentVersion": "3.1.2",
+    "currentVersion": "3.2.0",


@omerKarkKatz Is adding a new command considered a minor or revision?

This is more fit for a revision update, I will modify the version and release notes in the inner PR.

Packs/Jira/Integrations/JiraV3/JiraV3.py

omerKarkKatz · 2023-10-09T07:04:49Z

Hi @68zuhKQfKPk , we haven’t heard from you in a while.
Do you need any help with the pull request?

Please feel free to reach out to me here or on Slack.
Thanks again for contributing to our repo, hope to hear from you soon.

Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com>

CLAassistant · 2023-10-17T10:57:04Z

All committers have signed the CLA.

kPKfQKhuz86 · 2023-10-17T11:08:18Z

I think it's ready to be merged. Please review @omerKarkKatz

omerKarkKatz · 2023-10-17T16:42:12Z

@kPKfQKhuz86 Hey thank you for addressing all the required changes.
Please look at the Slack DFIR. I wrote you a message regarding the demo and the lack of unit test.
Thanks a lot, feel free to reach out for any further help.

kPKfQKhuz86 · 2023-10-18T10:17:41Z

Pushed unit tests for the command

kPKfQKhuz86 · 2023-10-26T11:56:03Z

Hello @omerKarkKatz , can we have it merged? :-)

omerKarkKatz · 2023-10-29T15:29:08Z

@kPKfQKhuz86 Sorry for the delay I had to run some tests.
I Merge this PR tomorrow.

…68zuhKQfKPk-contrib-Jira-1

* [Marketplace Contribution] Atlassian Jira - Content Pack Update (#29838) * "contribution update to pack "Atlassian Jira"" * Update YML * Update Readme * Add missing docstrings * Apply suggestions from code review Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Adjust response type to empty body response * Added periods on various strings, per pre-commit test failure * Unit tests for JIRA assignee --------- Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> * updated docker and fixed RN * added self to the class function * restored some yml marketplace download changeS * fixed the unit test * typing --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com>

* add a way to upload binary file (#30532) * add a way to upload binary file * patch ci/cd error * patch ci/cd error * Apply suggestions from code review Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> --------- Co-authored-by: Pierre SOLER <9917674+Winultimatum@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Docker Image To demisto/crypto (#30624) * Updated Metadata Of Pack AzureSecurityCenter * Added release notes to pack AzureSecurityCenter * Packs/AzureSecurityCenter/Integrations/AzureSecurityCenter_v2/AzureSecurityCenter_v2.yml Docker image update * fix jira convert issues print (#30608) fix jira convert issues print #30608 * fix merge dev secrets and sync buckets (#30609) fix merge dev secrets and sync buckets #30609 * Fixed Gitlab event collector fetch (#30379) * Fix GitLab collector * release notes * pre-commit fix * pre-commit fix * increase coverage * CR fixes * fix * Update 2_2_19.md * CR fix * default limit to 500 * update docker * Remove checking 6.2 server version (#30351) * removed usage of is_ge_version function with server version less than 6.2.0. * added rn * updated docker image * added rn * removed unit tests * fixed unittests * edit unittest * fixed unittest * edited unittests * edited unittests * mypy fixes * fixes * fixes * updated docker image * added rn * mypy fixes * edited unittests * edit * edit unit tests * edited the tpb to work with ng server * edited tpb * removed paging unit tests, removed arguments * reverted removing the args * Fix for dhcp (#30610) * Updated the modeling rule of microsoft dhcp * Updated the modeling rule of microsoft dhcp * Update 1_0_3.md --------- Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> * Xdr lite playbbok (#30497) * new incidents fields * New playbook,incident type,script,layout for xdr lite changing integration default incident type and classifier * resolve conflicts - RN * update RN, update unsearchable to true in incident fields and remove unnecessary incident fields from the layout * updated layout - InvestigationVerdict dynamic section * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixes after review * Update Packs/CortexXDR/Scripts/InvestigationVerdict/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fix for test playbooks Test_XDR_Playbook_execute_script_commands.yml * fix after review. change script name * RN after fixes * RN after fixes * change name of the script yml file in pack ignore * lint fix * time range fix --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * comment out us its looks unused and adding unchanged_files to the changed_files (#30632) * OpsGenie v3 - Fix polling commands (#30579) * fix get_request_command method * update RN * validate results.content is not empty * add "." to missing descriptions * added test_get_request_command_valid_raw_response * fix mypy * fix flake8 * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#30512) * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#29838) * "contribution update to pack "Atlassian Jira"" * Update YML * Update Readme * Add missing docstrings * Apply suggestions from code review Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Adjust response type to empty body response * Added periods on various strings, per pre-commit test failure * Unit tests for JIRA assignee --------- Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> * updated docker and fixed RN * added self to the class function * restored some yml marketplace download changeS * fixed the unit test * typing --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> --------- Co-authored-by: Pierre <Winultimatum@users.noreply.github.com> Co-authored-by: Pierre SOLER <9917674+Winultimatum@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: Koby Meir <kobymeir@users.noreply.github.com> Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: yasta5 <112320333+yasta5@users.noreply.github.com> Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> Co-authored-by: OmriItzhak <115150792+OmriItzhak@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>

* [Marketplace Contribution] Atlassian Jira - Content Pack Update (#29838) * "contribution update to pack "Atlassian Jira"" * Update YML * Update Readme * Add missing docstrings * Apply suggestions from code review Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Adjust response type to empty body response * Added periods on various strings, per pre-commit test failure * Unit tests for JIRA assignee --------- Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> * updated docker and fixed RN * added self to the class function * restored some yml marketplace download changeS * fixed the unit test * typing --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com>

* add a way to upload binary file (#30532) * add a way to upload binary file * patch ci/cd error * patch ci/cd error * Apply suggestions from code review Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> --------- Co-authored-by: Pierre SOLER <9917674+Winultimatum@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Docker Image To demisto/crypto (#30624) * Updated Metadata Of Pack AzureSecurityCenter * Added release notes to pack AzureSecurityCenter * Packs/AzureSecurityCenter/Integrations/AzureSecurityCenter_v2/AzureSecurityCenter_v2.yml Docker image update * fix jira convert issues print (#30608) fix jira convert issues print #30608 * fix merge dev secrets and sync buckets (#30609) fix merge dev secrets and sync buckets #30609 * Fixed Gitlab event collector fetch (#30379) * Fix GitLab collector * release notes * pre-commit fix * pre-commit fix * increase coverage * CR fixes * fix * Update 2_2_19.md * CR fix * default limit to 500 * update docker * Remove checking 6.2 server version (#30351) * removed usage of is_ge_version function with server version less than 6.2.0. * added rn * updated docker image * added rn * removed unit tests * fixed unittests * edit unittest * fixed unittest * edited unittests * edited unittests * mypy fixes * fixes * fixes * updated docker image * added rn * mypy fixes * edited unittests * edit * edit unit tests * edited the tpb to work with ng server * edited tpb * removed paging unit tests, removed arguments * reverted removing the args * Fix for dhcp (#30610) * Updated the modeling rule of microsoft dhcp * Updated the modeling rule of microsoft dhcp * Update 1_0_3.md --------- Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> * Xdr lite playbbok (#30497) * new incidents fields * New playbook,incident type,script,layout for xdr lite changing integration default incident type and classifier * resolve conflicts - RN * update RN, update unsearchable to true in incident fields and remove unnecessary incident fields from the layout * updated layout - InvestigationVerdict dynamic section * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixes after review * Update Packs/CortexXDR/Scripts/InvestigationVerdict/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fix for test playbooks Test_XDR_Playbook_execute_script_commands.yml * fix after review. change script name * RN after fixes * RN after fixes * change name of the script yml file in pack ignore * lint fix * time range fix --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * comment out us its looks unused and adding unchanged_files to the changed_files (#30632) * OpsGenie v3 - Fix polling commands (#30579) * fix get_request_command method * update RN * validate results.content is not empty * add "." to missing descriptions * added test_get_request_command_valid_raw_response * fix mypy * fix flake8 * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#30512) * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#29838) * "contribution update to pack "Atlassian Jira"" * Update YML * Update Readme * Add missing docstrings * Apply suggestions from code review Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Adjust response type to empty body response * Added periods on various strings, per pre-commit test failure * Unit tests for JIRA assignee --------- Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> * updated docker and fixed RN * added self to the class function * restored some yml marketplace download changeS * fixed the unit test * typing --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> --------- Co-authored-by: Pierre <Winultimatum@users.noreply.github.com> Co-authored-by: Pierre SOLER <9917674+Winultimatum@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: Koby Meir <kobymeir@users.noreply.github.com> Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: yasta5 <112320333+yasta5@users.noreply.github.com> Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> Co-authored-by: OmriItzhak <115150792+OmriItzhak@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>

"contribution update to pack "Atlassian Jira""

3cfb170

content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Sep 25, 2023

content-bot changed the base branch from master to contrib/xsoar-contrib_68zuhKQfKPk-contrib-Jira-1 September 25, 2023 14:45

content-bot assigned ostolero Sep 25, 2023

content-bot requested a review from ostolero September 25, 2023 14:45

68zuhKQfKPk added 5 commits September 25, 2023 15:00

Update YML

accd50a

Update Readme

ffd3e20

Merge branch 'contrib/xsoar-contrib_68zuhKQfKPk-contrib-Jira-1' into …

340ffbf

…68zuhKQfKPk-contrib-Jira-1

Merge branch 'contrib/xsoar-contrib_68zuhKQfKPk-contrib-Jira-1' into …

6e96863

…68zuhKQfKPk-contrib-Jira-1

Add missing docstrings

65e96e5

omerKarkKatz requested review from omerKarkKatz and removed request for ostolero October 1, 2023 07:28

omerKarkKatz assigned omerKarkKatz and unassigned ostolero Oct 1, 2023

omerKarkKatz requested a review from anas-yousef October 2, 2023 09:48

omerKarkKatz assigned omerKarkKatz and anas-yousef and unassigned omerKarkKatz Oct 2, 2023