Remove checking 6.2 server version #30351

merit-maita · 2023-10-23T12:49:55Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-8725

Description

removed usage of is_ge_version() method with version 6.2.0.

Must have

Tests
Documentation

… 6.2.0.

# Conflicts: # Packs/Base/ReleaseNotes/1_32_39.md # Packs/Base/pack_metadata.json

Packs/AlienVault_OTX/Integrations/AlienVault_OTX_v2/AlienVault_OTX_v2_test.py

DeanArbel · 2023-11-02T07:00:34Z

Packs/Base/Scripts/CommonServerPython/CommonServerPython.py

@@ -9646,9 +9642,9 @@ def __init__(self,
                 sort=None,
                 ):
        # searchAfter is available in searchIndicators from version 6.1.0
-        self._can_use_search_after = is_demisto_version_ge('6.1.0')
+        self._can_use_search_after = True


@merit-maita it'll be a cleaner implementation if you remove this argument and its usage.
The same goes for _can_use_filter_fields.
These are feature flags - since they are no longer needed, the old implementation isn't needed either.

DeanArbel · 2023-11-02T07:01:31Z

Packs/Base/Scripts/CommonServerPython/CommonServerPython_test.py

@@ -6843,8 +6803,8 @@ def test_iterator__empty_page(self, mocker):
        results = []
        for res in search_indicators:
            results.append(res)
-        assert len(results) == 0
-        assert search_indicators.page == 19
+        assert len(results) == 7


@merit-maita please remove the test, using the page search should no longer be supported after 6.2.

DeanArbel

Great job, well done.

* removed usage of is_ge_version function with server version less than 6.2.0. * added rn * updated docker image * added rn * removed unit tests * fixed unittests * edit unittest * fixed unittest * edited unittests * edited unittests * mypy fixes * fixes * fixes * updated docker image * added rn * mypy fixes * edited unittests * edit * edit unit tests * edited the tpb to work with ng server * edited tpb * removed paging unit tests, removed arguments * reverted removing the args

* add a way to upload binary file (#30532) * add a way to upload binary file * patch ci/cd error * patch ci/cd error * Apply suggestions from code review Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> --------- Co-authored-by: Pierre SOLER <9917674+Winultimatum@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Docker Image To demisto/crypto (#30624) * Updated Metadata Of Pack AzureSecurityCenter * Added release notes to pack AzureSecurityCenter * Packs/AzureSecurityCenter/Integrations/AzureSecurityCenter_v2/AzureSecurityCenter_v2.yml Docker image update * fix jira convert issues print (#30608) fix jira convert issues print #30608 * fix merge dev secrets and sync buckets (#30609) fix merge dev secrets and sync buckets #30609 * Fixed Gitlab event collector fetch (#30379) * Fix GitLab collector * release notes * pre-commit fix * pre-commit fix * increase coverage * CR fixes * fix * Update 2_2_19.md * CR fix * default limit to 500 * update docker * Remove checking 6.2 server version (#30351) * removed usage of is_ge_version function with server version less than 6.2.0. * added rn * updated docker image * added rn * removed unit tests * fixed unittests * edit unittest * fixed unittest * edited unittests * edited unittests * mypy fixes * fixes * fixes * updated docker image * added rn * mypy fixes * edited unittests * edit * edit unit tests * edited the tpb to work with ng server * edited tpb * removed paging unit tests, removed arguments * reverted removing the args * Fix for dhcp (#30610) * Updated the modeling rule of microsoft dhcp * Updated the modeling rule of microsoft dhcp * Update 1_0_3.md --------- Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> * Xdr lite playbbok (#30497) * new incidents fields * New playbook,incident type,script,layout for xdr lite changing integration default incident type and classifier * resolve conflicts - RN * update RN, update unsearchable to true in incident fields and remove unnecessary incident fields from the layout * updated layout - InvestigationVerdict dynamic section * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixes after review * Update Packs/CortexXDR/Scripts/InvestigationVerdict/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fix for test playbooks Test_XDR_Playbook_execute_script_commands.yml * fix after review. change script name * RN after fixes * RN after fixes * change name of the script yml file in pack ignore * lint fix * time range fix --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * comment out us its looks unused and adding unchanged_files to the changed_files (#30632) * OpsGenie v3 - Fix polling commands (#30579) * fix get_request_command method * update RN * validate results.content is not empty * add "." to missing descriptions * added test_get_request_command_valid_raw_response * fix mypy * fix flake8 * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#30512) * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#29838) * "contribution update to pack "Atlassian Jira"" * Update YML * Update Readme * Add missing docstrings * Apply suggestions from code review Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Adjust response type to empty body response * Added periods on various strings, per pre-commit test failure * Unit tests for JIRA assignee --------- Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> * updated docker and fixed RN * added self to the class function * restored some yml marketplace download changeS * fixed the unit test * typing --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> --------- Co-authored-by: Pierre <Winultimatum@users.noreply.github.com> Co-authored-by: Pierre SOLER <9917674+Winultimatum@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: Koby Meir <kobymeir@users.noreply.github.com> Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: yasta5 <112320333+yasta5@users.noreply.github.com> Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> Co-authored-by: OmriItzhak <115150792+OmriItzhak@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>

* removed usage of is_ge_version function with server version less than 6.2.0. * added rn * updated docker image * added rn * removed unit tests * fixed unittests * edit unittest * fixed unittest * edited unittests * edited unittests * mypy fixes * fixes * fixes * updated docker image * added rn * mypy fixes * edited unittests * edit * edit unit tests * edited the tpb to work with ng server * edited tpb * removed paging unit tests, removed arguments * reverted removing the args

* add a way to upload binary file (#30532) * add a way to upload binary file * patch ci/cd error * patch ci/cd error * Apply suggestions from code review Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> --------- Co-authored-by: Pierre SOLER <9917674+Winultimatum@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Docker Image To demisto/crypto (#30624) * Updated Metadata Of Pack AzureSecurityCenter * Added release notes to pack AzureSecurityCenter * Packs/AzureSecurityCenter/Integrations/AzureSecurityCenter_v2/AzureSecurityCenter_v2.yml Docker image update * fix jira convert issues print (#30608) fix jira convert issues print #30608 * fix merge dev secrets and sync buckets (#30609) fix merge dev secrets and sync buckets #30609 * Fixed Gitlab event collector fetch (#30379) * Fix GitLab collector * release notes * pre-commit fix * pre-commit fix * increase coverage * CR fixes * fix * Update 2_2_19.md * CR fix * default limit to 500 * update docker * Remove checking 6.2 server version (#30351) * removed usage of is_ge_version function with server version less than 6.2.0. * added rn * updated docker image * added rn * removed unit tests * fixed unittests * edit unittest * fixed unittest * edited unittests * edited unittests * mypy fixes * fixes * fixes * updated docker image * added rn * mypy fixes * edited unittests * edit * edit unit tests * edited the tpb to work with ng server * edited tpb * removed paging unit tests, removed arguments * reverted removing the args * Fix for dhcp (#30610) * Updated the modeling rule of microsoft dhcp * Updated the modeling rule of microsoft dhcp * Update 1_0_3.md --------- Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> * Xdr lite playbbok (#30497) * new incidents fields * New playbook,incident type,script,layout for xdr lite changing integration default incident type and classifier * resolve conflicts - RN * update RN, update unsearchable to true in incident fields and remove unnecessary incident fields from the layout * updated layout - InvestigationVerdict dynamic section * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixes after review * Update Packs/CortexXDR/Scripts/InvestigationVerdict/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fix for test playbooks Test_XDR_Playbook_execute_script_commands.yml * fix after review. change script name * RN after fixes * RN after fixes * change name of the script yml file in pack ignore * lint fix * time range fix --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * comment out us its looks unused and adding unchanged_files to the changed_files (#30632) * OpsGenie v3 - Fix polling commands (#30579) * fix get_request_command method * update RN * validate results.content is not empty * add "." to missing descriptions * added test_get_request_command_valid_raw_response * fix mypy * fix flake8 * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#30512) * [Marketplace Contribution] Atlassian Jira - Content Pack Update (#29838) * "contribution update to pack "Atlassian Jira"" * Update YML * Update Readme * Add missing docstrings * Apply suggestions from code review Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> * Adjust response type to empty body response * Added periods on various strings, per pre-commit test failure * Unit tests for JIRA assignee --------- Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> * updated docker and fixed RN * added self to the class function * restored some yml marketplace download changeS * fixed the unit test * typing --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> --------- Co-authored-by: Pierre <Winultimatum@users.noreply.github.com> Co-authored-by: Pierre SOLER <9917674+Winultimatum@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: Koby Meir <kobymeir@users.noreply.github.com> Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: yasta5 <112320333+yasta5@users.noreply.github.com> Co-authored-by: eepstain <116078117+eepstain@users.noreply.github.com> Co-authored-by: OmriItzhak <115150792+OmriItzhak@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: 68zuhKQfKPk <98105006+68zuhKQfKPk@users.noreply.github.com> Co-authored-by: kPKfQKhuz86 <147484800+kPKfQKhuz86@users.noreply.github.com> Co-authored-by: anas-yousef <44998563+anas-yousef@users.noreply.github.com> Co-authored-by: omerKarkKatz <95565843+omerKarkKatz@users.noreply.github.com> Co-authored-by: Jakob Weinzettl <jakob.weinzettl@group.issworld.com> Co-authored-by: okarkkatz <okarkkatz@paloaltonetworks.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>

merit-maita added 30 commits October 23, 2023 15:17

removed usage of is_ge_version function with server version less than…

6a42d57

… 6.2.0.

added rn

db8426a

updated docker image

bae8967

Merge branch 'master' into Remove_checking_6.2_server_version

1eec546

# Conflicts: # Packs/Base/ReleaseNotes/1_32_39.md # Packs/Base/pack_metadata.json

added rn

a39d71c

Merge branch 'master' into Remove_checking_6.2_server_version

62e3e27

removed unit tests

e0d607b

fixed unittests

1517be0

Merge branch 'master' into Remove_checking_6.2_server_version

ef5642a

edit unittest

0038d9d

Merge branch 'master' into Remove_checking_6.2_server_version

094b12f

fixed unittest

09ea479

Merge branch 'master' into Remove_checking_6.2_server_version

2320777

edited unittests

2afc176

Merge branch 'master' into Remove_checking_6.2_server_version

612d994

edited unittests

3943436

mypy fixes

3cbe083

fixes

38484a3

Merge branch 'master' into Remove_checking_6.2_server_version

39c967e

fixes

14b85eb

Merge branch 'master' into Remove_checking_6.2_server_version

9d9a1f5

updated docker image

6aed779

Merge branch 'master' into Remove_checking_6.2_server_version

d632820

added rn

a1232aa

mypy fixes

322276e

edited unittests

d1a4e86

Merge branch 'master' into Remove_checking_6.2_server_version

b534d47

edit

5bdb238

edit unit tests

25897e5

Merge branch 'master' into Remove_checking_6.2_server_version

3ede376

merit-maita requested a review from Ni-Knight as a code owner October 30, 2023 11:58

merit-maita requested review from thefrieddan1 and DeanArbel and removed request for Ni-Knight October 30, 2023 12:25

merit-maita added 2 commits October 31, 2023 15:06

Merge branch 'master' into Remove_checking_6.2_server_version

0ab44c1

Merge branch 'master' into Remove_checking_6.2_server_version

3e7f4a9

DeanArbel reviewed Nov 1, 2023

View reviewed changes

Packs/AlienVault_OTX/Integrations/AlienVault_OTX_v2/AlienVault_OTX_v2_test.py Show resolved Hide resolved

merit-maita added 5 commits November 1, 2023 12:57

edited the tpb to work with ng server

4597094

Merge branch 'master' into Remove_checking_6.2_server_version

69e2599

edited tpb

de11eb3

Merge branch 'master' into Remove_checking_6.2_server_version

e4e5e70

Merge branch 'master' into Remove_checking_6.2_server_version

0a5571f

DeanArbel reviewed Nov 2, 2023

View reviewed changes

merit-maita added 2 commits November 2, 2023 09:48

Merge branch 'master' into Remove_checking_6.2_server_version

3f1c612

removed paging unit tests, removed arguments

c81ad00

DeanArbel approved these changes Nov 2, 2023

View reviewed changes

reverted removing the args

5fdf83f

merit-maita added the docs-approved label Nov 2, 2023

merit-maita merged commit a1d2836 into master Nov 2, 2023
20 checks passed

merit-maita deleted the Remove_checking_6.2_server_version branch November 2, 2023 11:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove checking 6.2 server version #30351

Remove checking 6.2 server version #30351

merit-maita commented Oct 23, 2023 •

edited

DeanArbel Nov 2, 2023

DeanArbel Nov 2, 2023

DeanArbel left a comment

Remove checking 6.2 server version #30351

Remove checking 6.2 server version #30351

Conversation

merit-maita commented Oct 23, 2023 • edited

Status

Related Issues

Description

Must have

DeanArbel Nov 2, 2023

Choose a reason for hiding this comment

DeanArbel Nov 2, 2023

Choose a reason for hiding this comment

DeanArbel left a comment

Choose a reason for hiding this comment

merit-maita commented Oct 23, 2023 •

edited