Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] SplunkShortID #30101

Merged

Conversation

content-bot
Copy link
Collaborator

@content-bot content-bot commented Oct 9, 2023

Original External PR

external pull request

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@linuxpakistan

Description

Create Splunk Notable Event Short ID.

This contribution was donated as a new pack with only one script. Since we don't typically create packs with just one script, and adding it to the SplunkPY pack would require bringing the script up to XSOAR support standards (which isn't feasible), I consulted with @ilappe and we decided to add the script to an existing pack created by the same contributor. I also renamed that existing pack to be more general, so it can accommodate a wider variety of content going forward.

In summary: I renamed an existing pack and added the new script into it.

Notes

This is newscript and it depends upon the SplunkPy integration command splunk-search.

Auto-Generated Documentation Requiring Modification

Video Link

N/A

* "pack contribution initial commit"

* change eventid to event_id

* docker

---------

Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved post-demo pending-contributor The PR is pending the response of its creator Community Support Level Indicates that the contribution is for Community supported pack Internal PR labels Oct 9, 2023
@guardrails
Copy link

guardrails bot commented Oct 9, 2023

⚠️ We detected 1 security issue in this pull request:

Insecure Use of Crypto (1)
Severity Details Docs
Low Title: Insecure hash functions
sha1_object = hashlib.sha1(notable_eventid) # nosec
📚

More info on how to fix Insecure Use of Crypto in Python.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@RosenbergYehuda RosenbergYehuda removed the request for review from JasBeilin October 15, 2023 20:24
@RosenbergYehuda RosenbergYehuda merged commit da32003 into master Oct 16, 2023
14 of 15 checks passed
@RosenbergYehuda RosenbergYehuda deleted the contrib/xsoar-contrib_linuxpakistan-contrib-SplunkShortID branch October 16, 2023 13:15
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* [Marketplace Contribution] SplunkShortID (#29830)

* "pack contribution initial commit"

* change eventid to event_id

* docker

---------

Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>

* rename and migrate the packs

* docker

* format

* delete RN

* Revert "rename and migrate the packs"

This reverts commit 812a3cc08470d6a338412f5ea9e0ec2720be3b64.

* rearrange

* RN

* [known_words]

* try ignore hash1 warning

* RN

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Yehuda <yrosenberg@paloaltonetworks.com>
Co-authored-by: Yehuda Rosenberg <90599084+RosenbergYehuda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Contribution Thank you! Contributions are always welcome! docs-approved Internal PR pending-contributor The PR is pending the response of its creator post-demo
Projects
None yet
3 participants