Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Marketplace Contribution] Microsoft Defender for Endpoint - Content Pack Update #30323

Merged
merged 1 commit into from Oct 23, 2023
Merged

[Marketplace Contribution] Microsoft Defender for Endpoint - Content Pack Update #30323

merged 1 commit into from Oct 23, 2023

Conversation

xsoar-bot
Copy link
Contributor

Warning
The changes in the contributed files were not made on the most updated pack versions

Item Name Contribution Pack Version Latest Pack Version
Microsoft Defender Advanced Threat Protection 1.16.11 1.16.14

For the Reviewer:

  1. Compare the code of this PR with the latest version of the pack. Make sure you understand the changes the contributor intended to contribute, and solve the conflicts accordingly.
  2. In case improvements are needed, instruct the contributor to edit the code through the GitHub Codespaces and Not through the XSOAR UI.

For the Contributor:
@amontminypa
In case you are requested by your reviewer to improve the code or to make changes, submit them through the GitHub Codespaces and Not through the XSOAR UI.

To use the GitHub Codespaces, do the following:

  1. Click the 'Code' button in the right upper corner of this PR.
  2. Click 'Create codespace on Transformers'.
  3. Click 'Authorize and continue'.
  4. Wait until your Codespace environment is generated. When it is, you can edit your code.
  5. Commit and push your changes to the head branch of the PR.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@amontminypa

Notes

Just updated the list options in the integration configuration for the microsoft-atp-update-alert command. No changes to code were made.

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Oct 19, 2023
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_amontminypa-contrib-MicrosoftDefenderAdvancedThreatProtection October 19, 2023 21:21
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @MosheEichler will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution, please ask the reviewer to update your information in the pack contributors file. See more information here link

MosheEichler
MosheEichler reviewed Oct 22, 2023
View reviewed changes
Copy link
Contributor

@MosheEichler MosheEichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amontminypa,
Thank you for your contribution!
Good work :)

Please see my comments.

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again

...tions/MicrosoftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection.py
@@ -1305,7 +1309,7 @@ def run_antivirus_scan(self, machine_id, comment, scan_type):

Args:
machine_id (str): Machine ID
comment (str): Comment to associate with the action
comment (str): Comment to associate with the action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
comment (str): Comment to associate with the action
comment (str): Comment to associate with the action

...tions/MicrosoftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection.py
Comment on lines +1 to +2
import demistomock as demisto # noqa: F401
from CommonServerPython import * # noqa: F401
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import demistomock as demisto # noqa: F401
from CommonServerPython import * # noqa: F401

Please remove.

Packs/ApiModules/Scripts/MicrosoftApiModule/MicrosoftApiModule.py
Comment on lines 1 to +3
from CommonServerPython import * # noqa: F401
import demistomock as demisto # noqa: F401

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from CommonServerPython import * # noqa: F401
import demistomock as demisto # noqa: F401
import demistomock as demisto # noqa: F401
from CommonServerPython import * # noqa: F401

Revert just to remove the diff.

...tions/MicrosoftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection.py
import urllib3
from dateutil.parser import parse
from requests import Response

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Revert just to remove the diff.

...oftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection_description.md
@@ -7,7 +7,7 @@ There are 2 application authentication methods available:

* [Cortex XSOAR Application](https://xsoar.pan.dev/docs/reference/articles/microsoft-integrations---authentication#cortex-xsoar-application)
* [Self-Deployed Application](https://xsoar.pan.dev/docs/reference/articles/microsoft-integrations---authentication#self-deployed-application)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Revert just to remove the diff.

...ions/MicrosoftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection.yml
Comment on lines -2 to -4
sectionOrder:
- Connect
- Collect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert.

...ions/MicrosoftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection.yml
@@ -39,6 +36,7 @@ configuration:
type: 9
hiddenusername: true
required: false
display: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
display: ''

...ions/MicrosoftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection.yml
@@ -96,6 +94,7 @@ configuration:
type: 9
section: Connect
required: false
display: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
display: ''

...ions/MicrosoftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection.yml
additionalinfo: More information can be found on https://cortex.marketplace.pan.dev/marketplace/details/MicrosoftDefenderAdvancedThreatProtection/
required: false
- additionalinfo: Select this checkbox if you are using a self-deployed Azure application.
display: Use a self-deployed Azure Application
name: self_deployed
type: 8
section: Connect
advanced: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed it in purpose?

...ions/MicrosoftDefenderAdvancedThreatProtection/MicrosoftDefenderAdvancedThreatProtection.yml
Comment on lines +236 to +240
- defaultvalue: '1'
display: Incidents Fetch Interval
name: incidentFetchInterval
required: false
type: 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add this parameter?

@MosheEichler MosheEichler added the pending-contributor The PR is pending the response of its creator label Oct 22, 2023
@MosheEichler MosheEichler merged commit c310e63 into demisto:contrib/xsoar-contrib_amontminypa-contrib-MicrosoftDefenderAdvancedThreatProtection Oct 23, 2023
30 of 39 checks passed
@content-bot content-bot mentioned this pull request Oct 23, 2023
Merged
3 tasks
MosheEichler added a commit that referenced this pull request Oct 23, 2023
@content-bot @xsoar-bot
@MosheEichler @ShirleyDenkberg
[Marketplace Contribution] Microsoft Defender for Endpoint - Content …
7a88105 
…Pack Update (#30338)

* "contribution update to pack "Microsoft Defender for Endpoint"" (#30323)

* revert

* Update Packs/MicrosoftDefenderAdvancedThreatProtection/ReleaseNotes/1_16_15.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* docker

* RN

* RN

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
@content-bot @xsoar-bot
@MosheEichler @ShirleyDenkberg
[Marketplace Contribution] Microsoft Defender for Endpoint - Content …
585886a 
…Pack Update (#30338)

* "contribution update to pack "Microsoft Defender for Endpoint"" (#30323)

* revert

* Update Packs/MicrosoftDefenderAdvancedThreatProtection/ReleaseNotes/1_16_15.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* docker

* RN

* RN

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MosheEichler MosheEichler MosheEichler approved these changes

@michal-dagan michal-dagan Awaiting requested review from michal-dagan

Assignees

@MosheEichler MosheEichler

Labels
Contribution Thank you! Contributions are always welcome! External PR pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
3 participants
@xsoar-bot @content-bot @MosheEichler