Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud user investigation inputs description fix #30965

Merged
merged 13 commits into from Nov 21, 2023
Merged

Cloud user investigation inputs description fix #30965

merged 13 commits into from Nov 21, 2023

Conversation

OmriItzhak
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Updated the outputs description for cloud user investigation - generic playbook

Must have

  • Tests
  • Documentation

@OmriItzhak
Merge branch 'master' of github.com:demisto/content into cloud_user_i…
0f284fb 
…nvestigation_inputs_description_fix

� Conflicts:
�	Packs/CommonPlaybooks/pack_metadata.json
@OmriItzhak
updated the outputs description - RN pack meta date
92c8421
idovandijk
idovandijk requested changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@idovandijk idovandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I commented on some outputs that should be Boolean instead of String. Please update them and regenerate playbook README, then ping me and I'll approve :)

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonPlaybooks pack version was bumped to 2.4.26.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@ShirleyDenkberg
Copy link
Contributor

@idovandijk Doc review completed.

OmriItzhak and others added 3 commits November 20, 2023 16:36
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonPlaybooks pack version was bumped to 2.4.27.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonPlaybooks pack version was bumped to 2.4.28.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

idovandijk
idovandijk approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@idovandijk idovandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@OmriItzhak OmriItzhak merged commit c82f337 into master Nov 21, 2023
17 checks passed
@OmriItzhak OmriItzhak deleted the cloud_user_investigation_inputs_description_fix branch November 21, 2023 11:58
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
@OmriItzhak @ShirleyDenkberg
Cloud user investigation inputs description fix (#30965)
821e173 
* updated the outputs description

* updated the outputs description - RN

* updated the outputs description - RN pack meta date

* Bump pack from version CommonPlaybooks to 2.4.26.

* updated the outputs types - Boolean

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Bump pack from version CommonPlaybooks to 2.4.27.

* Bump pack from version CommonPlaybooks to 2.4.28.

---------

Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@idovandijk idovandijk idovandijk approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

@OmriItzhak OmriItzhak

Labels
docs-approved
Projects
None yet
Milestone
No milestone
4 participants
@OmriItzhak @content-bot @ShirleyDenkberg @idovandijk