Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed auto closing tickets in service now #31194

Merged
merged 12 commits into from Dec 17, 2023
Merged

Conversation

eyalpalo
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Due to a bug, we closed every ticket we open in service now, without watching if we should.

Must have

  • Tests
  • Documentation

@eyalpalo eyalpalo marked this pull request as ready for review December 13, 2023 07:57
##### ServiceNow v2
- Updated the Docker image to: *demisto/python3:3.10.13.83255*.

- Fixed an issue with mirror-out functionality where tickets were not being closed properly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed an issue with mirror-out functionality where tickets were not being closed properly.
- Fixed an issue with the outgoing mirroring functionality where newly created tickets were incorrectly closed.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • ServiceNow pack version was bumped to 2.5.48.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@eyalpalo eyalpalo merged commit b23eb58 into master Dec 17, 2023
18 of 19 checks passed
@eyalpalo eyalpalo deleted the XSUP_30790_service_now branch December 17, 2023 07:20
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* fix

* tests

* rn

* format

* rn

* Bump pack from version ServiceNow to 2.5.48.

* revert and bug fix

* cr

---------

Co-authored-by: Content Bot <bot@demisto.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* fix

* tests

* rn

* format

* rn

* Bump pack from version ServiceNow to 2.5.48.

* revert and bug fix

* cr

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants