Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate demisto-api-* commands #31388

Merged
merged 71 commits into from
Dec 20, 2023
Merged

Deprecate demisto-api-* commands #31388

merged 71 commits into from
Dec 20, 2023

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Dec 10, 2023 •
edited
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue
content-docs pr: demisto/content-docs#1440

Description

Deprecate all the demisto-api-* commands.
Replace their usage in OOB scripts and playbooks.

Must have

  • Tests
  • Documentation

@michal-dagan michal-dagan changed the title Deprecate demisto api commands Deprecate demisto-api-* commands Dec 10, 2023
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.12.57.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@michal-dagan michal-dagan marked this pull request as ready for review December 11, 2023 14:27
ShirleyDenkberg
ShirleyDenkberg reviewed Dec 11, 2023
View reviewed changes
Packs/DemistoRESTAPI/ReleaseNotes/1_3_41.md Outdated Show resolved Hide resolved
Packs/DemistoRESTAPI/ReleaseNotes/1_3_41.md Outdated Show resolved Hide resolved
Packs/DemistoRESTAPI/ReleaseNotes/1_3_41.md Outdated Show resolved Hide resolved
Packs/DemistoRESTAPI/ReleaseNotes/1_3_41.md Outdated Show resolved Hide resolved
Packs/DemistoRESTAPI/ReleaseNotes/1_3_41.md Outdated Show resolved Hide resolved
Packs/DemistoRESTAPI/ReleaseNotes/1_3_41.md Outdated Show resolved Hide resolved
@ShirleyDenkberg ShirleyDenkberg self-assigned this Dec 11, 2023
@ShirleyDenkberg
Copy link
Contributor

@DeanArbel @mmhw I reviewed the 1_3_41.md RN file as requested. Doc review completed.

michal-dagan and others added 5 commits December 17, 2023 15:03
@michal-dagan
Merge remote-tracking branch 'origin/master' into deprecate-demisto-a…
76d224e 
…pi-commands

# Conflicts:
#	Packs/CommonPlaybooks/ReleaseNotes/2_4_40.json
#	Packs/CommonPlaybooks/ReleaseNotes/2_4_40.md
#	Packs/CommonScripts/ReleaseNotes/1_13_7.md
#	Packs/EmailCommunication/ReleaseNotes/2_0_16.json
#	Packs/EmailCommunication/ReleaseNotes/2_0_16.md
@michal-dagan
Merge remote-tracking branch 'origin/deprecate-demisto-api-commands' …
8131f3e 
…into deprecate-demisto-api-commands
@michal-dagan
Merge remote-tracking branch 'origin/master' into deprecate-demisto-a…
4ffe8f2 
…pi-commands

# Conflicts:
#	Packs/CommonPlaybooks/ReleaseNotes/2_4_41.md
Merged master into current branch.
7121b44
Bump pack from version CommonPlaybooks to 2.4.42.
b1a8960
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonPlaybooks pack version was bumped to 2.4.42.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@michal-dagan michal-dagan added the ForceMerge Forcing the merge of the PR despite the build status label Dec 17, 2023
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.13.9.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonPlaybooks pack version was bumped to 2.4.43.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • DeveloperTools pack version was bumped to 1.3.8.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@DeanArbel DeanArbel merged commit 5e6fc98 into master Dec 20, 2023
15 of 19 checks passed
@DeanArbel DeanArbel deleted the deprecate-demisto-api-commands branch December 20, 2023 08:07
@michal-dagan
Copy link
Contributor Author

michal-dagan commented Dec 20, 2023 •
edited
Loading

force-merge:
CJ105 -
Packs/Troubleshoot/Scripts/TroubleshootIsDockerImageExists/TroubleshootIsDockerImageExists.yml - [CJ105]
Packs/DemistoRESTAPI/Scripts/GetIncidentTasksByState/GetIncidentTasksByState.yml - [CJ105]
Packs/Troubleshoot/Scripts/TroubleshootTestInstance/TroubleshootTestInstance.yml - [CJ105]
Packs/ContentManagement/Scripts/JobCreator/JobCreator.yml - [CJ105]
Packs/Troubleshoot/Scripts/TroubleshootGetInstanceParameters/TroubleshootGetInstanceParameters.yml - [CJ105]
GR103 -
/builds/xsoar/content/Packs/ContentManagement/Playbooks/playbook-Configuration_Setup.yml - [GR103] - opened a ticket:
https://jira-dc.paloaltonetworks.com/browse/CIAC-9211

xsoar_ng_server_ga - opened a ticket: https://jira-dc.paloaltonetworks.com/browse/CIAC-9238

content-bot pushed a commit that referenced this pull request Dec 20, 2023
@michal-dagan
Deprecate demisto-api-* commands (#31388)
a1337a0 
* deprecate all the demisto-api-* commands.
Replace their usage in OOB scripts and playbooks.

* pre-commit

* update rn

* demisto-sdk format

* demisto-sdk format + update rn

* format

* fixed Mypy and Pylint errors

* Bump pack from version CommonScripts to 1.12.57.

* updated dockers

* validation fixes

* validation fixes

* updated rn dockers

* updated rn 1_3_41.md

* updated rn+integration name

* updated rn+bc

* fixed

* fixed

* Bump pack from version CommonScripts to 1.12.58.

* fixed

* fixed

* fixed

* Bump pack from version CommonScripts to 1.13.1.

* cr updates

* cr updates

* fixed

* Bump pack from version DeveloperTools to 1.3.7.

* Bump pack from version CommonScripts to 1.13.2.

* Bump pack from version CommonScripts to 1.13.6.

* Bump pack from version CommonScripts to 1.13.7.

* Bump pack from version CommonPlaybooks to 2.4.42.

* fixed

* fixed

* changed to test_data

* fixed

* Bump pack from version CommonScripts to 1.13.9.

* Bump pack from version CommonPlaybooks to 2.4.43.

* Bump pack from version DeveloperTools to 1.3.8.

---------

Co-authored-by: Content Bot <bot@demisto.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
@michal-dagan @maimorag
Deprecate demisto-api-* commands (#31388)
d25d148 
* deprecate all the demisto-api-* commands.
Replace their usage in OOB scripts and playbooks.

* pre-commit

* update rn

* demisto-sdk format

* demisto-sdk format + update rn

* format

* fixed Mypy and Pylint errors

* Bump pack from version CommonScripts to 1.12.57.

* updated dockers

* validation fixes

* validation fixes

* updated rn dockers

* updated rn 1_3_41.md

* updated rn+integration name

* updated rn+bc

* fixed

* fixed

* Bump pack from version CommonScripts to 1.12.58.

* fixed

* fixed

* fixed

* Bump pack from version CommonScripts to 1.13.1.

* cr updates

* cr updates

* fixed

* Bump pack from version DeveloperTools to 1.3.7.

* Bump pack from version CommonScripts to 1.13.2.

* Bump pack from version CommonScripts to 1.13.6.

* Bump pack from version CommonScripts to 1.13.7.

* Bump pack from version CommonPlaybooks to 2.4.42.

* fixed

* fixed

* changed to test_data

* fixed

* Bump pack from version CommonScripts to 1.13.9.

* Bump pack from version CommonPlaybooks to 2.4.43.

* Bump pack from version DeveloperTools to 1.3.8.

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@DeanArbel DeanArbel DeanArbel approved these changes

@mmhw mmhw Awaiting requested review from mmhw mmhw is a code owner

@michalgold michalgold Awaiting requested review from michalgold

@idovandijk idovandijk Awaiting requested review from idovandijk idovandijk is a code owner

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michal-dagan @content-bot @ShirleyDenkberg @DeanArbel