Google Cloud Storage - Update gcs-list-bucket-objects to support prefix and delimiter arguments. #31496

zdrouse · 2023-12-15T20:59:00Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

The google cloud storage python client supports these arguments.
https://github.com/googleapis/python-storage/blob/main/samples/snippets/storage_list_files_with_prefix.py

Description

Add support prefix and delimiter support for gcs-list-bucket-objects command. This will allow users to limit blobs returned from a GCS bucket.

Must have

Tests
Documentation

added arguments for prefix and delimiter to gcs_list_bucket_objects to support limiting results returned for blobs that are in "folders"

added arguments to support updates for gcs-list-bucket-objects to include prefix and delimiter parameters

content-bot · 2023-12-15T21:00:40Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @adi88d will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

content-bot · 2023-12-15T21:00:40Z

Hi @zdrouse, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

spelling

adi88d

Great Job!
Thanks a lot for this contribution, It is highly appreciated.
I added some review comments and suggestion:

remove the Packs/GoogleCloudStorage/CONTRIBUTORS.json file
update release notes for the pack using demisto-sdk update-release-notes command
add to the delimiter and prefix arguments toGoogleCloudStorage/README.md

Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.yml

CLAassistant · 2023-12-17T19:04:57Z

All committers have signed the CLA.

…eCloudStorage.yml Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

zdrouse

I committed the suggestion for YAML file although I'm not sure I understand it since all the other arguments and commands already implemented don't follow it

ShirleyDenkberg · 2023-12-18T14:42:12Z

Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.yml

@@ -119,6 +119,10 @@ script:
    - default: true
      description: Name of the bucket in which to list objects. If not specified, operation will be performed on the default bucket parameter.
      name: bucket_name
+    - description: Specify to limit blobs within a "folder" i.e. "folder-1/" if blob is "folder-1/file.txt".


Suggested change

- description: Specify to limit blobs within a "folder" i.e. "folder-1/" if blob is "folder-1/file.txt".

- description: Specify to limit blobs within a "folder" i.e., "folder-1/" if blob is "folder-1/file.txt".

ShirleyDenkberg · 2023-12-18T14:42:39Z

Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.yml

@@ -119,6 +119,10 @@ script:
    - default: true
      description: Name of the bucket in which to list objects. If not specified, operation will be performed on the default bucket parameter.
      name: bucket_name
+    - description: Specify to limit blobs within a "folder" i.e. "folder-1/" if blob is "folder-1/file.txt".
+      name: prefix
+    - description: Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e. "/".


Suggested change

- description: Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e. "/".

- description: Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e., "/".

ShirleyDenkberg · 2023-12-18T14:43:01Z

Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/README.md

@@ -291,6 +291,16 @@
 <td style="width: 421px;">Name of the bucket in which to list objects.</td>
 <td style="width: 103px;">Required</td>
 </tr>
+<tr>
+<td style="width: 184px;">prefix</td>
+<td style="width: 421px;">Specify to limit blobs within a "folder" i.e. "folder-1/" if blob is "folder-1/file.txt".</td>


Suggested change

<td style="width: 421px;">Specify to limit blobs within a "folder" i.e. "folder-1/" if blob is "folder-1/file.txt".</td>

<td style="width: 421px;">Specify to limit blobs within a "folder" i.e., "folder-1/" if blob is "folder-1/file.txt".</td>

ShirleyDenkberg · 2023-12-18T14:43:13Z

Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/README.md

+</tr>
+<tr>
+<td style="width: 184px;">delimiter</td>
+<td style="width: 421px;">Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e. "/".</td>


Suggested change

<td style="width: 421px;">Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e. "/".</td>

<td style="width: 421px;">Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e., "/".</td>

ShirleyDenkberg · 2023-12-18T14:43:33Z

Packs/GoogleCloudStorage/ReleaseNotes/1_0_12.md

+  - ***delimiter***
+  - ***prefix***


Suggested change

- ***delimiter***

- ***prefix***

- *delimiter*

- *prefix*

ShirleyDenkberg · 2023-12-18T14:43:54Z

Packs/GoogleCloudStorage/ReleaseNotes/1_0_12.md

+
+##### Google Cloud Storage
+
+- Added the following arguments to the **gcs-list-bucket-objects** command:


Suggested change

- Added the following arguments to the **gcs-list-bucket-objects** command:

- Added the following arguments to the ***gcs-list-bucket-objects*** command:

ShirleyDenkberg · 2023-12-18T14:48:09Z

@adi88d Doc review completed.

…ix and delimiter arguments. (#31496) (#31537) * Update GoogleCloudStorage.py added arguments for prefix and delimiter to gcs_list_bucket_objects to support limiting results returned for blobs that are in "folders" * Update GoogleCloudStorage.yml added arguments to support updates for gcs-list-bucket-objects to include prefix and delimiter parameters * Create CONTRIBUTORS.json * Update GoogleCloudStorage.yml spelling * Update Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.yml * added arguments to README * fix arguments to README * updated arguments to README * fix argument descriptions in GoogleCloudStorage.yml * fix yml structure * update RN * update docker * doc review --------- Co-authored-by: zdrouse <zdrouse@gmail.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> Co-authored-by: adi88d <adaud@paloaltonetworks.com>

zdrouse added 2 commits December 15, 2023 15:41

Update GoogleCloudStorage.py

4cf1830

added arguments for prefix and delimiter to gcs_list_bucket_objects to support limiting results returned for blobs that are in "folders"

Update GoogleCloudStorage.yml

7056c37

added arguments to support updates for gcs-list-bucket-objects to include prefix and delimiter parameters

content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Dec 15, 2023

content-bot changed the base branch from master to contrib/zdrouse_master December 15, 2023 21:00

content-bot assigned adi88d Dec 15, 2023

content-bot requested a review from adi88d December 15, 2023 21:00

content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Dec 15, 2023

zdrouse added 2 commits December 15, 2023 16:08

Create CONTRIBUTORS.json

9a1968a

Update GoogleCloudStorage.yml

77c728a

spelling

adi88d requested changes Dec 17, 2023

View reviewed changes

Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.yml Outdated Show resolved Hide resolved

adi88d added the pending-contributor The PR is pending the response of its creator label Dec 17, 2023

Merge branch 'demisto:master' into master

1597dd9

zdrouse requested review from yucohen, michal-dagan, michalgold and idovandijk as code owners December 17, 2023 19:04

Update Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/Googl…

50bc4bd

…eCloudStorage.yml Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

zdrouse commented Dec 17, 2023

View reviewed changes

zdrouse and others added 6 commits December 17, 2023 14:25

added arguments to README

ffbd346

fix arguments to README

22373eb

updated arguments to README

efa40fa

fix argument descriptions in GoogleCloudStorage.yml

565c58d

fix yml structure

546ed13

update RN

adebe10

adi88d removed request for michalgold, idovandijk, yucohen and michal-dagan December 18, 2023 14:33

adi88d assigned ShirleyDenkberg Dec 18, 2023

update docker

17b55e6

ShirleyDenkberg reviewed Dec 18, 2023

View reviewed changes

ShirleyDenkberg added the docs-approved label Dec 18, 2023

doc review

a83de4b

adi88d merged commit 4409c9c into demisto:contrib/zdrouse_master Dec 18, 2023
14 of 21 checks passed

content-bot mentioned this pull request Dec 18, 2023

Google Cloud Storage - Update gcs-list-bucket-objects to support prefix and delimiter arguments. #31537

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Google Cloud Storage - Update gcs-list-bucket-objects to support prefix and delimiter arguments. #31496

Google Cloud Storage - Update gcs-list-bucket-objects to support prefix and delimiter arguments. #31496

zdrouse commented Dec 15, 2023 •

edited

content-bot commented Dec 15, 2023

content-bot commented Dec 15, 2023

adi88d left a comment

CLAassistant commented Dec 17, 2023 •

edited

zdrouse left a comment

ShirleyDenkberg Dec 18, 2023

ShirleyDenkberg Dec 18, 2023

ShirleyDenkberg Dec 18, 2023

ShirleyDenkberg Dec 18, 2023

ShirleyDenkberg Dec 18, 2023

ShirleyDenkberg Dec 18, 2023

ShirleyDenkberg commented Dec 18, 2023

	- description: Specify to limit blobs within a "folder" i.e. "folder-1/" if blob is "folder-1/file.txt".
	- description: Specify to limit blobs within a "folder" i.e., "folder-1/" if blob is "folder-1/file.txt".

	- description: Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e. "/".
	- description: Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e., "/".

	<td style="width: 421px;">Specify to limit blobs within a "folder" i.e. "folder-1/" if blob is "folder-1/file.txt".</td>
	<td style="width: 421px;">Specify to limit blobs within a "folder" i.e., "folder-1/" if blob is "folder-1/file.txt".</td>

	<td style="width: 421px;">Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e. "/".</td>
	<td style="width: 421px;">Use a delimiter if you want to limit results within a specific "folder" and without any nested blobs i.e., "/".</td>


		##### Google Cloud Storage

		- Added the following arguments to the gcs-list-bucket-objects command:

Google Cloud Storage - Update gcs-list-bucket-objects to support prefix and delimiter arguments. #31496

Google Cloud Storage - Update gcs-list-bucket-objects to support prefix and delimiter arguments. #31496

Conversation

zdrouse commented Dec 15, 2023 • edited

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Must have

content-bot commented Dec 15, 2023

content-bot commented Dec 15, 2023

adi88d left a comment

Choose a reason for hiding this comment

CLAassistant commented Dec 17, 2023 • edited

zdrouse left a comment

Choose a reason for hiding this comment

ShirleyDenkberg Dec 18, 2023

Choose a reason for hiding this comment

ShirleyDenkberg Dec 18, 2023

Choose a reason for hiding this comment

ShirleyDenkberg Dec 18, 2023

Choose a reason for hiding this comment

ShirleyDenkberg Dec 18, 2023

Choose a reason for hiding this comment

ShirleyDenkberg Dec 18, 2023

Choose a reason for hiding this comment

ShirleyDenkberg Dec 18, 2023

Choose a reason for hiding this comment

ShirleyDenkberg commented Dec 18, 2023

zdrouse commented Dec 15, 2023 •

edited

CLAassistant commented Dec 17, 2023 •

edited