Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud Storage - Update gcs-list-bucket-objects to support prefix and delimiter arguments. #31537

Merged
merged 3 commits into from Dec 19, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@zdrouse

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

The google cloud storage python client supports these arguments.
https://github.com/googleapis/python-storage/blob/main/samples/snippets/storage_list_files_with_prefix.py

Description

Add support prefix and delimiter support for gcs-list-bucket-objects command. This will allow users to limit blobs returned from a GCS bucket.

Must have

  • Tests
  • Documentation

…ix and delimiter arguments. (#31496)

* Update GoogleCloudStorage.py

added arguments for prefix and delimiter to gcs_list_bucket_objects to support limiting results returned for blobs that are in "folders"

* Update GoogleCloudStorage.yml

added arguments to support updates for gcs-list-bucket-objects to include prefix and delimiter parameters

* Create CONTRIBUTORS.json

* Update GoogleCloudStorage.yml

spelling

* Update Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.yml

Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

* added arguments to README

* fix arguments to README

* updated arguments to README

* fix argument descriptions in GoogleCloudStorage.yml

* fix yml structure

* update RN

* update docker

* doc review

---------

Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR labels Dec 18, 2023
@adi88d adi88d merged commit 2a97819 into master Dec 19, 2023
17 of 18 checks passed
@adi88d adi88d deleted the contrib/zdrouse_master branch December 19, 2023 10:53
content-bot added a commit that referenced this pull request Dec 20, 2023
…ix and delimiter arguments. (#31496) (#31537)

* Update GoogleCloudStorage.py

added arguments for prefix and delimiter to gcs_list_bucket_objects to support limiting results returned for blobs that are in "folders"

* Update GoogleCloudStorage.yml

added arguments to support updates for gcs-list-bucket-objects to include prefix and delimiter parameters

* Create CONTRIBUTORS.json

* Update GoogleCloudStorage.yml

spelling

* Update Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.yml



* added arguments to README

* fix arguments to README

* updated arguments to README

* fix argument descriptions in GoogleCloudStorage.yml

* fix yml structure

* update RN

* update docker

* doc review

---------

Co-authored-by: zdrouse <zdrouse@gmail.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
…ix and delimiter arguments. (#31496) (#31537)

* Update GoogleCloudStorage.py

added arguments for prefix and delimiter to gcs_list_bucket_objects to support limiting results returned for blobs that are in "folders"

* Update GoogleCloudStorage.yml

added arguments to support updates for gcs-list-bucket-objects to include prefix and delimiter parameters

* Create CONTRIBUTORS.json

* Update GoogleCloudStorage.yml

spelling

* Update Packs/GoogleCloudStorage/Integrations/GoogleCloudStorage/GoogleCloudStorage.yml



* added arguments to README

* fix arguments to README

* updated arguments to README

* fix argument descriptions in GoogleCloudStorage.yml

* fix yml structure

* update RN

* update docker

* doc review

---------

Co-authored-by: zdrouse <zdrouse@gmail.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
3 participants